Skip to content

Commit e8564fc

Browse files
author
red0sena
committed
update azure-collector fix None type issue
1 parent eda5202 commit e8564fc

3 files changed

Lines changed: 18 additions & 13 deletions

File tree

collector/spot-dataset/azure/lambda/current_collector/load_price.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,6 @@ def collect_price_with_multithreading():
137137

138138
price_df = pd.DataFrame(price_list)
139139
savings_df = preprocessing_price(price_df)
140-
savings_df = savings_df.drop_duplicates(subset=['InstanceTier', 'InstanceType', 'Region'], keep='first', inplace=True)
140+
savings_df = savings_df.drop_duplicates(subset=['InstanceTier', 'InstanceType', 'Region'], keep='first')
141141

142142
return savings_df

collector/spot-dataset/azure/lambda/current_collector/upload_data.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,8 @@ def query_selector(data):
142142

143143

144144
def upload_cloudwatch(data, timestamp):
145-
ondemand_count = len(data.drop(columns=['SpotPrice', 'Savings']).dropna())
146-
spot_count = len(data.drop(columns=['OndemandPrice', 'Savings']).dropna())
145+
ondemand_count = len(data.drop(columns=['IF', 'SpotPrice', 'Savings']).dropna())
146+
spot_count = len(data.drop(columns=['IF', 'OndemandPrice', 'Savings']).dropna())
147147
if_count = len(data.drop(columns=['OndemandPrice', 'SpotPrice', 'Savings']).dropna())
148148

149149
cw_client = boto3.client('logs')

const_config.py

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,15 @@ def func_set(self, value):
55

66
def func_get(self):
77
return func()
8+
89
return property(func_get, func_set)
910

11+
1012
class Storage(object):
1113
@constant
1214
def BUCKET_NAME():
1315
return "spotlake"
14-
16+
1517
@constant
1618
def DATABASE_NAME():
1719
return "spotlake"
@@ -28,6 +30,7 @@ def AZURE_TABLE_NAME():
2830
def GCP_TABLE_NAME():
2931
return "gcp"
3032

33+
3134
class AwsCollector(object):
3235
@constant
3336
def LOCAL_PATH():
@@ -45,6 +48,7 @@ def S3_LOCAL_FILES_SAVE_PATH():
4548
def S3_WORKLOAD_SAVE_PATH():
4649
return "rawdata/aws/workloads"
4750

51+
4852
class AzureCollector(object):
4953
@constant
5054
def SLACK_WEBHOOK_URL():
@@ -57,7 +61,7 @@ def GET_EVICTION_RATE_URL():
5761
@constant
5862
def GET_HARDWAREMAP_URL():
5963
return "https://afd.hosting.portal.azure.net/compute/?environmentjson=true&extensionName=Microsoft_Azure_Compute&l=en&trustedAuthority=portal.azure.com"
60-
64+
6165
@constant
6266
def GET_PRICE_URL():
6367
return "https://s2.billing.ext.azure.com/api/Billing/Subscription/GetSpecsCosts?SpotPricing=true"
@@ -71,17 +75,17 @@ def SPEC_RESOURCE_SETS_LIMIT():
7175
return 2000
7276

7377
@constant
74-
def LATEST_FILENAME ():
78+
def LATEST_FILENAME():
7579
return "latest_azure.json"
7680

7781
@constant
7882
def S3_LATEST_DATA_SAVE_PATH():
7983
return "latest_data/latest_azure.json"
80-
84+
8185
@constant
8286
def QUERY_SELECTOR_FILENAME():
8387
return "query-selector-azure.json"
84-
88+
8589
@constant
8690
def S3_QUERY_SELECTOR_SAVE_PATH():
8791
return "query-selector/query-selector-azure.json"
@@ -105,11 +109,11 @@ def SERVER_SAVE_FILENAME():
105109
@constant
106110
def GET_PRICE_URL():
107111
return "https://prices.azure.com:443/api/retail/prices?$filter=serviceName eq 'Virtual Machines' and priceType eq 'Consumption' and unitOfMeasure eq '1 Hour' and contains(productName, 'Windows') eq false and contains(meterName, 'Low Priority') eq false and contains(meterName, 'Expired') eq false and contains(location, 'Gov') eq false and contains(location, 'ATT') eq false &$skip="
108-
112+
109113
@constant
110114
def FILTER_LOCATIONS():
111115
return ['GOV', 'EUAP', 'ATT', 'SLV', '']
112-
116+
113117
@constant
114118
def MAX_SKIP():
115119
return 200
@@ -122,6 +126,7 @@ def SPOT_DATA_COLLECTION_LOG_GROUP_NAME():
122126
def LOG_STREAM_NAME():
123127
return "Azure-Count"
124128

129+
125130
class GcpCollector(object):
126131
@constant
127132
def API_LINK():
@@ -134,11 +139,11 @@ def S3_LATEST_DATA_SAVE_PATH():
134139
@constant
135140
def LOCAL_PATH():
136141
return "/tmp"
137-
142+
138143
@constant
139144
def SPOT_DATA_COLLECTION_LOG_GROUP_NAME():
140145
return "Collection-Data-Count"
141-
146+
142147
@constant
143148
def LOG_STREAM_NAME():
144-
return "GCP-Count"
149+
return "GCP-Count"

0 commit comments

Comments
 (0)