fix(cypress): streamline logging in media library and login functions for improved clarity

Author: martinjagodic

cypress/e2e/common/media_library.js

@@ -14,18 +14,13 @@ import {
 import { workflowStatus } from '../../utils/constants';
 
 function uploadMediaFile() {
-  cy.task('log', '[media_library] uploadMediaFile: start');
   assertNoImagesInLibrary();
-  cy.task('log', '[media_library] uploadMediaFile: library empty confirmed');
 
   const fixture = 'cypress/fixtures/media/netlify.png';
   cy.get('input[type="file"]').selectFile(fixture, { force: true });
-  cy.task('log', '[media_library] uploadMediaFile: file selected');
   cy.contains('span', 'Uploading...').should('not.exist');
-  cy.task('log', '[media_library] uploadMediaFile: upload finished');
 
   assertImagesInLibrary();
-  cy.task('log', '[media_library] uploadMediaFile: image present');
 }
 
 function assertImagesInLibrary() {
@@ -107,19 +102,14 @@ function assertGridEntryImage(entry) {
 
 export default function({ entries, getUser }) {
   beforeEach(() => {
-    cy.task('log', '[media_library beforeEach] start login');
     login(getUser && getUser());
-    cy.task('log', '[media_library beforeEach] login completed');
   });
 
   it('can upload image from global media library', () => {
-    cy.task('log', '[TEST] can upload image from global media library: start');
     goToMediaLibrary();
-    cy.task('log', '[TEST] can upload image from global media library: media library opened');
     uploadMediaFile();
     matchImageSnapshot();
     closeMediaLibrary();
-    cy.task('log', '[TEST] can upload image from global media library: end');
   });
 
   it('can delete image from global media library', () => {

cypress/e2e/common/spec_utils.js

@@ -65,24 +65,13 @@ export function afterEach(taskResult, backend) {
     const {
       suite: {
         ctx: {
-          currentTest: { state, _retries: retries, _currentRetry: currentRetry, err },
+          currentTest: { state, _retries: retries, _currentRetry: currentRetry },
         },
       },
     } = Cypress.mocha.getRunner();
 
-    cy.task(
-      'log',
-      `[afterEach] backend=${backend} test="${testName}" state=${state} retry=${currentRetry}/${retries}`,
-    );
-    if (state === 'failed' && err?.message) {
-      cy.task('log', `[afterEach] failure: ${err.message}`);
-    }
-
     if (state === 'failed' && retries === currentRetry) {
-      // Avoid deadlock in headless CI: runner.stop can leave recorded parallel runs hanging.
-      if (Cypress.config('isInteractive')) {
-        Cypress.runner.stop();
-      }
+      Cypress.runner.stop();
     }
   }
 }

cypress/support/e2e.js

@@ -33,17 +33,6 @@ import './commands';
 
 afterEach(function () {
   if (this.currentTest.state === 'failed') {
-    const titlePath = this.currentTest.titlePath ? this.currentTest.titlePath().join(' > ') : '';
-    // In headless CI, stopping the runner can leave the Cypress process hanging.
-    if (Cypress.config('isInteractive')) {
-      Cypress.runner.stop();
-    } else {
-      // eslint-disable-next-line no-console
-      console.error(`[afterEach] Test failed in CI: ${titlePath || this.currentTest.title}`);
-      if (this.currentTest.err?.message) {
-        // eslint-disable-next-line no-console
-        console.error(`[afterEach] Failure: ${this.currentTest.err.message}`);
-      }
-    }
+    Cypress.runner.stop();
   }
 });

cypress/utils/steps.js

@@ -9,13 +9,8 @@ const {
 } = require('./constants');
 
 function login(user) {
-  cy.task(
-    'log',
-    `[login] start user=${user ? 'yes' : 'no'} netlifySiteURL=${user?.netlifySiteURL ? 'yes' : 'no'}`,
-  );
   cy.viewport(1200, 1200);
   if (user) {
-    cy.task('log', '[login] about to visit /');
     cy.visit('/', {
       onBeforeLoad: () => {
         // https://github.com/cypress-io/cypress/issues/1208
@@ -25,26 +20,19 @@ function login(user) {
           window.localStorage.setItem('netlifySiteURL', user.netlifySiteURL);
         }
       },
-    }).then(() => {
-      cy.task('log', '[login] visit completed');
     });
     if (user.netlifySiteURL && user.email && user.password) {
-      cy.task('log', '[login] filling login form');
       cy.get('input[name="email"]', { timeout: 10000 }).clear();
       cy.get('input[name="email"]').type(user.email);
       cy.get('input[name="password"]').clear();
       cy.get('input[name="password"]').type(user.password);
       cy.contains('button', 'Login').click();
-      cy.task('log', '[login] login button clicked');
     }
   } else {
     cy.visit('/');
     cy.contains('button', 'Login').click();
   }
-  cy.task('log', '[login] waiting for New Post link');
-  cy.contains('a', 'New Post', { timeout: 60000 }).then(() => {
-    cy.task('log', '[login] New Post link found');
-  });
+  cy.contains('a', 'New Post');
 }
 
 function assertNotification(message) {