streamline hot water temp and flow are wrong

[diablodale]

Streamline skin shows wrong temp and wrong flow during hot water dispensing. Probably related to the tcl code below. It looks like the code is errantly displaying the same data for both dispensing hot water and flushing (aka rinse).

de1app/de1plus/skins/Streamline/skin.tcl

Lines 733 to 746 in 0fc61ac

	set flush_btns ""
	lappend flush_btns \
	[list -text "Temp" -font "Inter-Bold18" -foreground $::dataline_label_color ] \
	[list -text " " -font "Inter-Bold18"] \
	[list -text {[lindex [return_temperature_measurement_no_unit [watertemp] 1 1] 0]} -font "mono12" -foreground $::dataline_data_color ] \
	[list -text {[lindex [return_temperature_measurement_no_unit [watertemp] 1 1] 1]} -font "mono8" -foreground $::dataline_data_color ] \
	[list -text " " -font "Inter-SemiBold18"] \
	[list -text "Flow" -font "Inter-Bold18" -foreground $::dataline_label_color ] \
	[list -text " " -font "Inter-Bold18"] \
	[list -text {[round_to_integer $::settings(flush_flow)]} -font "mono12" -foreground $::dataline_data_color ] \
	[list -text {[translate ml/s]} -font "mono8" -foreground $::dataline_data_color ]
	add_de1_rich_text "hotwaterrinse water" 690 330 left 1 2 65 $::background_color $flush_btns
	add_de1_rich_text "hotwaterrinse_zoomed water_zoomed" 50 330 left 1 2 65 $::background_color $flush_btns

Setup

• de1pro 1.45
• de1app 1.45.0.4

Repo

1. App, calibrate, set hot water flow rate=10.0, set flush flow rate=6.0
2. Click OK and return to main streamline "page".
3. At left, tap hot water, tap temp, set to 75c
4. tap GHC to dispense hot water
5. Watch the flow and temp displayed on the hot water page

Result

Hot water temp is incorrect 92c.
Hot water flow is incorrect 6ml/s.
They seem to be showing values (and the tcl code supports this) related to flush temp+flow.

Expected

Hot water temp = 75c
Hot water flow = 10 ml/s

[decentjohn]

Thanks, will check it out.

[decentjohn]

Sorry for the delay in looking at this.

You pointed out a problem, but I think there's a different problem.

Namely, it doesn't seem to me like setting "hot water temperature" setting actually works, even in Insight. Insight doesn't show the actual temperature of the hot water coming out, whereas Streamline does, so perhaps this was not noticed.

Hot water appears to always use the temperature of the first step of Espresso.

Here's how I tested:

• set the hot water temp to 11C
• put my finger under the hot water output
• it feels very hot

But yes, you were also right that the Setting for hot water was being displayed, not the actual output. I've fixed that. ccac4a7

Could you do your own test on the hot water temperature, to confirm for me what I think I'm seeing? I could very well be confused and fooling myself.

[decentjohn]

As to the displaying the correct flow rate of FLUSH vs HOT WATER. At the moment, it appears to work. I set both in CALIBRATE, and Streamline reports what I actually set:

[decentjohn]

As discussed on Diaspora, temp control over hot water appears to work, but minimum actual temperature the DE1 can do is about 50ºC. However, the firmware doesn't report the actual water temperature being dispensed, and that's now a firmware fix todo.

[diablodale]

got it. I asked in decent bbs https://3.basecamp.com/3671212/buckets/7351439/messages/8647657573#__recording_9026048887 how to test the fix and the latest posts are that it requires either a full dev+git setup on the tablet -or- changing to nightly which is random in which fixes it includes. Former I have not the time+priority to radically change and maintance that on my machine. Latter, is rando rapid changes and doesn't provide a fixed build for my level of customer testing this change. So for now, I am unable to test your fix and I will test it in stable.