clean IsHoverEnabled, include worlds on favorites & warning reduction

Author: lorux0

Explorer/Assets/DCL/Navmap/PlaceInfoPanelController.cs

@@ -187,7 +187,7 @@ public void Set(PlacesData.PlaceInfo place)
             thumbnailImage.RequestImage(place.image);
             view.PlaceNameLabel.text = place.title;
             view.CreatorNameLabel.text = $"created by <b>{place.contact_name}</b>";
-            view.LikeRateLabel.text = $"{(place.like_rate_as_float ?? 0) * 100:F0}%";
+            view.LikeRateLabel.text = $"{(place.LikeRateAsFloat ?? 0) * 100:F0}%";
             view.PlayerCountLabel.text = place.user_count.ToString();
             view.DescriptionLabel.text = string.IsNullOrEmpty(place.description) ? "No description" : place.description;
             view.DescriptionLabel.ConvertUrlsToClickeableLinks(OpenUrl);

Explorer/Assets/DCL/Navmap/SearchForPlaceAndShowResultsCommand.cs

@@ -3,7 +3,6 @@
 using DCL.PlacesAPIService;
 using System.Collections.Generic;
 using System.Threading;
-using UnityEngine;
 using UnityEngine.Pool;
 
 namespace DCL.Navmap
@@ -124,8 +123,7 @@ private async UniTask ProcessPlacesAsync(CancellationToken ct)
                         ct,
                         pageNumber: @params.page, pageSize: @params.pageSize,
                         sortByBy: sort, sortDirection: sortDirection,
-                        onlySdk7: true,
-                        onlyPlaces: true);
+                        onlySdk7: true);
                     places.AddRange(response.Data);
                     totalResultCount = response.Total;
                 }

Explorer/Assets/DCL/Navmap/SearchResultPanelController.cs

@@ -54,6 +54,7 @@ public void ClearResults()
         {
             foreach ((string _, PlaceElementView fullSearchResultsView) in usedPoolElements)
             {
+                fullSearchResultsView.IsHoverEnabled = true;
                 fullSearchResultsView.resultButton.onClick.RemoveAllListeners();
                 fullSearchResultsView.resultAnimator.Rebind();
                 fullSearchResultsView.resultAnimator.Update(0f);

Explorer/Assets/DCL/Places/PlaceCardView.cs

@@ -159,7 +159,7 @@ public void Configure(PlaceInfo placeInfo, string ownerName, bool userOwnsPlace,
             int onlineMembers = placeInfo.connected_addresses?.Length ?? placeInfo.user_count;
             onlineMembersText.text = $"{onlineMembers}";
             onlineMembersContainer.SetActive(onlineMembers > 0);
-            likeRateText.text = $"{(placeInfo.like_rate_as_float ?? 0) * 100:F0}%";
+            likeRateText.text = $"{(placeInfo.LikeRateAsFloat ?? 0) * 100:F0}%";
             placeCoordsText.text = string.IsNullOrWhiteSpace(placeInfo.world_name) ? placeInfo.base_position : placeInfo.world_name;
             featuredTag.SetActive(placeInfo.highlighted);
 

Explorer/Assets/DCL/Places/PlaceDetailPanelView.cs

@@ -190,7 +190,7 @@ public void ConfigurePlaceData(
             creatorNameText.gameObject.SetActive(!string.IsNullOrEmpty(placeInfo.contact_name));
             creatorWalletText.text = !string.IsNullOrEmpty(placeInfo.owner) && placeInfo.owner.Length >= 10 ? $"{placeInfo.owner[..5]}...{placeInfo.owner[^5..]}" : "Unknown";
             creatorWalletText.gameObject.SetActive(string.IsNullOrEmpty(placeInfo.contact_name));
-            likeRateText.text = $"{(placeInfo.like_rate_as_float ?? 0) * 100:F0}%";
+            likeRateText.text = $"{(placeInfo.LikeRateAsFloat ?? 0) * 100:F0}%";
             visitsText.text = UIUtils.NumberToCompactString(placeInfo.user_visits);
             SilentlySetLikeToggle(placeInfo.user_like);
             SilentlySetDislikeToggle(placeInfo.user_dislike);

Explorer/Assets/DCL/PlacesAPIService/PlacesAPIResponse.cs

@@ -25,6 +25,7 @@ public class PlaceInfo : ISerializationCallbackReceiver
         {
             private const string EMPTY_PLACE_ID = "fake_id";
 
+            // ReSharper disable InconsistentNaming
             public string id;
             public string title;
             public string description;
@@ -67,6 +68,8 @@ public class PlaceInfo : ISerializationCallbackReceiver
 
             [SerializeField] private string[] positions;
 
+            // ReSharper restore InconsistentNaming
+
             public bool IsEmptyPlace => id == EMPTY_PLACE_ID;
 
             [JsonIgnore]
@@ -122,7 +125,7 @@ public PlaceInfo(Vector2Int position)
             }
 
             [JsonIgnore]
-            public float? like_rate_as_float
+            public float? LikeRateAsFloat
             {
                 get
                 {
@@ -173,22 +176,26 @@ public void OnAfterDeserialize()
             [Serializable]
             public class Realm
             {
+                // ReSharper disable InconsistentNaming
                 public string serverName;
                 public string layer;
                 public string url;
                 public int usersCount;
                 public int maxUsers;
                 public Vector2Int[] userParcels;
+                // ReSharper restore InconsistentNaming
             }
         }
 
         // TODO: This class should be moved to the PlacesAPIService folder
         [Serializable]
         public class PlacesAPIResponse : PaginatedResponse, IPlacesAPIResponse
         {
+            // ReSharper disable InconsistentNaming
             public bool ok;
             public int total;
             public List<PlaceInfo> data;
+            // ReSharper restore InconsistentNaming
 
             int IPlacesAPIResponse.Total => total;
             IReadOnlyList<PlaceInfo> IPlacesAPIResponse.Data => data;
@@ -213,16 +220,20 @@ public interface IPlacesAPIResponse : IDisposable
         [Serializable]
         public class PlacesAPIGetParcelResponse
         {
+            // ReSharper disable InconsistentNaming
             public bool ok;
             public PlaceInfo data;
+            // ReSharper restore InconsistentNaming
         }
 
     }
 
     [Serializable]
     public class OptimizedPlaceInMapResponse
     {
+        // ReSharper disable InconsistentNaming
         public Vector2Int base_position;
         public string name;
+        // ReSharper restore InconsistentNaming
     }
 }