Merge branch 'dev' into feat/deeplink-param-backpack

Author: davidejensen

.claude/skills/code-standards/SKILL.md

@@ -29,6 +29,8 @@ user-invocable: false
 
 **Exception:** serialized JSON DTO fields keep their wire-format casing — see *Serialized JSON DTOs* below.
 
+**Namespaces are domain names, not folder paths** — never suppress a folder-namespace mismatch with `// ReSharper disable once CheckNamespace`; fix the namespace or leave the warning visible. Full rule: `docs/code-style-guidelines.md` § Namespaces.
+
 ## Member Ordering
 
 Within a class, group members in this order:

.github/workflows/pr-comment-warnings.yml

@@ -73,6 +73,7 @@ jobs:
           {
             echo "body<<EOF"
             echo "<!-- warning-ratchet -->"
+            blocked=false
             if [ -z "$BASELINE" ]; then
               echo "**Warnings counted: $COUNT** (no baseline established yet)"
             elif [ "$COUNT" -lt "$BASELINE" ]; then
@@ -81,6 +82,27 @@ jobs:
               echo "**Warnings unchanged: $BASELINE => $COUNT** — allowed on release/hotfix branches."
             else
               echo "**Warnings not reduced: $BASELINE => $COUNT** — remove at least one warning to merge."
+              blocked=true
+            fi
+
+            # Always list the warnings/errors in files this PR changed; expand only when blocking.
+            total=$(jq -r '.pr_findings_total // 0' warning-result.json)
+            if [ "$total" -gt 0 ]; then
+              open_attr=""
+              [ "$blocked" = "true" ] && open_attr=" open"
+              echo ""
+              echo "<details$open_attr><summary>Warnings/errors in files changed by this PR ($total)</summary>"
+              echo ""
+              echo "| File | Line | Rule | Message |"
+              echo "| --- | --- | --- | --- |"
+              jq -r '.pr_findings[] | "| \(.file) | \(.line) | \(.rule) | \(.message | gsub("[|\r\n]"; " ")) |"' warning-result.json
+              shown=$(jq -r '.pr_findings | length' warning-result.json)
+              if [ "$total" -gt "$shown" ]; then
+                echo ""
+                echo "_…and $((total - shown)) more (see the \`csharp-lint-reports\` artifact)._"
+              fi
+              echo ""
+              echo "</details>"
             fi
             echo "EOF"
           } >> "$GITHUB_OUTPUT"

.github/workflows/test.yml

@@ -398,6 +398,44 @@ jobs:
           aws s3 cp baseline.json "s3://$EXPLORER_TEAM_S3_BUCKET/${{ env.WARNINGS_BASELINE_S3_KEY }}" \
             --content-type application/json --cache-control no-cache
 
+      # Warnings/errors located in files this PR changed — surfaced in the PR comment.
+      - name: Collect PR-file warnings
+        if: ${{ !cancelled() && github.event_name == 'pull_request' }}
+        id: pr-findings
+        env:
+          BASE_REF: ${{ github.event.pull_request.base.ref }}
+          HEAD_SHA: ${{ github.event.pull_request.head.sha }}
+          MAX_FINDINGS: 50   # max rows listed in the PR comment; change here
+        run: |
+          set -euo pipefail
+          echo '[]' > pr-findings.json
+          echo "total=0" >> "$GITHUB_OUTPUT"
+          [ -f filtered.json ] || exit 0
+
+          base=$(git merge-base "origin/$BASE_REF" "$HEAD_SHA" 2>/dev/null || true)
+          [ -n "$base" ] || { echo "No merge-base - skipping PR-file findings."; exit 0; }
+
+          # repo-relative paths -> project-relative (strip leading 'Explorer/')
+          git diff --name-only "$base" "$HEAD_SHA" -- '*.cs' \
+            | sed 's#^Explorer/##' | sort -u > changed-files.txt
+
+          jq --rawfile changed changed-files.txt '
+            ($changed | split("\n") | map(select(length > 0))) as $files
+            | map({
+                file:    (.locations[0].physicalLocation.artifactLocation.uri // ""),
+                line:    (.locations[0].physicalLocation.region.startLine // 0),
+                rule:    (.ruleId // ""),
+                level:   (.level // "warning"),
+                message: (.message.text // "")
+              })
+            | map(select(.file as $f | $files | index($f) != null))
+          ' filtered.json > pr-findings-all.json
+
+          total=$(jq length pr-findings-all.json)
+          jq --argjson max "$MAX_FINDINGS" '.[:$max]' pr-findings-all.json > pr-findings.json   # cap comment size
+          echo "total=$total" >> "$GITHUB_OUTPUT"
+          echo "PR-file findings: $total (listing up to $MAX_FINDINGS)"
+
       # Hand the numbers to the trusted workflow_run companion that posts the PR comment.
       # Runs even when the gate above failed (!cancelled), so a failing run still refreshes the comment
       # instead of leaving a stale message.
@@ -416,7 +454,9 @@ jobs:
             --argjson count "$COUNT" \
             --arg baseline "$BASELINE" \
             --argjson allow_equal "$IS_RELEASE_OR_HOTFIX" \
-            '{pr: $pr, count: $count, baseline: (if $baseline == "" then null else ($baseline | tonumber) end), allow_equal: $allow_equal}' \
+            --slurpfile findings pr-findings.json \
+            --argjson findings_total "${{ steps.pr-findings.outputs.total || 0 }}" \
+            '{pr: $pr, count: $count, baseline: (if $baseline == "" then null else ($baseline | tonumber) end), allow_equal: $allow_equal, pr_findings: ($findings[0] // []), pr_findings_total: $findings_total}' \
             > warning-result.json
           cat warning-result.json
 

CLAUDE.md

@@ -131,6 +131,7 @@ Reviewers have repeatedly identified AI-generated code by these smells. Check yo
 * **Wiring pooled/virtualized list items per rebind.** For item pools, wire callbacks once when the item is created, not every time `SetItemData` runs. Prefer an `Action` field (single subscriber, direct assignment) over C# `event` (`+=`/`-=` churn) when there is exactly one subscriber.
 * **Reimplementing primitives that already exist.** Before writing manual atlas UV math, check `TMP_Sprite Asset`. Before hand-batching profile lookups, check the batched `GetProfilesAsync(IReadOnlyList<string>, ct)` overload. Before adding a bespoke event pathway, check `ViewEventBus` / `ChatEvents`.
 * **Comments that narrate caller/external behavior.** A comment must state only what the annotated code itself does or guarantees ("remove the corrupt file so the next read doesn't hit it"), never what callers or upper layers will do with the result ("so callers treat it as a miss and re-download"). External behavior can change without this code changing, silently turning the comment into a lie.
+* **Suppressing `CheckNamespace` with a ReSharper comment.** Never add `// ReSharper disable once CheckNamespace` (or the file-wide variant) — fix the namespace or leave the warning visible. Rationale and full rule: [`docs/code-style-guidelines.md` § Namespaces](docs/code-style-guidelines.md#namespaces).
 
 ### Other project-specific rules
 

Explorer/Assets/AddressableAssetsData/AssetGroups/Essentials.asset

@@ -380,6 +380,11 @@ MonoBehaviour:
     m_ReadOnly: 0
     m_SerializedLabels: []
     FlaggedDuringContentUpdateRestriction: 0
+  - m_GUID: fe492edbd0cef4457951fba2129d4c0a
+    m_Address: CreditsPurchaseModal
+    m_ReadOnly: 0
+    m_SerializedLabels: []
+    FlaggedDuringContentUpdateRestriction: 0
   m_ReadOnly: 0
   m_Settings: {fileID: 11400000, guid: fc8a9d2b539788c47a5b305639fa8b34, type: 2}
   m_SchemaSet:

Explorer/Assets/DCL/ApplicationGuards/ApplicationBlocklistGuard/BannedNotificationHandler.cs

@@ -20,7 +20,7 @@ public class BannedNotificationHandler : IDisposable
         private readonly IWeb3IdentityCache identityCache;
         private readonly ModerationDataProvider moderationDataProvider;
         private readonly IMVCManager mvcManager;
-        private readonly IWebBrowser webBrowser;
+        private readonly UnityAppWebBrowser webBrowser;
 
         private CancellationTokenSource cts = new ();
 
@@ -30,7 +30,7 @@ public BannedNotificationHandler(
             IWeb3IdentityCache identityCache,
             ModerationDataProvider moderationDataProvider,
             IMVCManager mvcManager,
-            IWebBrowser webBrowser)
+            UnityAppWebBrowser webBrowser)
         {
             this.webRequestController = webRequestController;
             this.urlsSource = urlsSource;
@@ -47,7 +47,7 @@ public void Dispose() =>
             cts.SafeCancelAndDispose();
 
         private void OnBanWarningNotificationClicked(object[] parameters) =>
-            webBrowser.OpenUrl(urlsSource.Url(DecentralandUrl.SupportLink));
+            webBrowser.OpenUrlMainThreadOnly(urlsSource.Url(DecentralandUrl.SupportLink));
 
         private void OnBannedNotificationClicked(object[] parameters)
         {

Explorer/Assets/DCL/ApplicationGuards/ApplicationBlocklistGuard/BlockedScreenController.cs

@@ -14,12 +14,12 @@ public class BlockedScreenController : ControllerBase<BlockedScreenView, Blocked
     {
         private const string DEFAULT_INFO_TEXT = "Contact Support for more information.";
 
-        private readonly IWebBrowser webBrowser;
+        private readonly UnityAppWebBrowser webBrowser;
         private readonly StringBuilder infoTextBuilder = new ();
 
         public override CanvasOrdering.SortingLayer Layer => CanvasOrdering.SortingLayer.OVERLAY;
 
-        public BlockedScreenController(ViewFactoryMethod viewFactory, IWebBrowser webBrowser) : base(viewFactory)
+        public BlockedScreenController(ViewFactoryMethod viewFactory, UnityAppWebBrowser webBrowser) : base(viewFactory)
         {
             this.webBrowser = webBrowser;
         }
@@ -66,7 +66,7 @@ public override void Dispose()
 
         private void OnSupportClicked()
         {
-            webBrowser.OpenUrl(DecentralandUrl.Help);
+            webBrowser.OpenUrlMainThreadOnly(DecentralandUrl.Help);
         }
 
         private static string FormatRemainingBanTime(string expiresAt)

Explorer/Assets/DCL/ApplicationGuards/ApplicationMinimumSpecsGuard/UI/MinimumSpecsScreenController.cs

@@ -11,7 +11,7 @@ namespace DCL.ApplicationGuards
 {
     public class MinimumSpecsScreenController : ControllerBase<MinimumSpecsScreenView>
     {
-        private readonly IWebBrowser webBrowser;
+        private readonly UnityAppWebBrowser webBrowser;
         private readonly IAnalyticsController analytics;
         private readonly IReadOnlyList<SpecResult> specResult;
         public override CanvasOrdering.SortingLayer Layer => CanvasOrdering.SortingLayer.OVERLAY;
@@ -20,7 +20,7 @@ public class MinimumSpecsScreenController : ControllerBase<MinimumSpecsScreenVie
         private MinimumSpecsTablePresenter specsTablePresenter;
 
         public MinimumSpecsScreenController(ViewFactoryMethod viewFactory,
-            IWebBrowser webBrowser,
+            UnityAppWebBrowser webBrowser,
             IAnalyticsController analytics,
             IReadOnlyList<SpecResult> specResult) : base(viewFactory)
         {
@@ -66,7 +66,7 @@ private void OnContinueClicked()
 
         private void OnReadMoreClicked()
         {
-            webBrowser.OpenUrl(DecentralandUrl.MinimumSpecs);
+            webBrowser.OpenUrlMainThreadOnly(DecentralandUrl.MinimumSpecs);
         }
 
         protected override UniTask WaitForCloseIntentAsync(CancellationToken ct) =>

Explorer/Assets/DCL/ApplicationGuards/ApplicationVersionGuard/ApplicationVersionGuard.cs

@@ -31,9 +31,9 @@ public class ApplicationVersionGuard
         private const string DECENTRALAND_LEGACY_LAUNCHER_MAC_X_64_DMG = "Decentraland Outdated-mac-x64.dmg";
 
         private readonly IWebRequestController webRequestController;
-        private readonly IWebBrowser webBrowser;
+        private readonly UnityAppWebBrowser webBrowser;
 
-        public ApplicationVersionGuard(IWebRequestController webRequestController, IWebBrowser webBrowser)
+        public ApplicationVersionGuard(IWebRequestController webRequestController, UnityAppWebBrowser webBrowser)
         {
             this.webRequestController = webRequestController;
             this.webBrowser = webBrowser;
@@ -89,7 +89,7 @@ private void DownloadLauncher()
             string downloadUrl = $"{GetLauncherDownloadPath()}/{assetName}";
 
             if (!string.IsNullOrEmpty(downloadUrl))
-                webBrowser.OpenUrl(downloadUrl);
+                webBrowser.OpenUrlMainThreadOnly(downloadUrl);
             else
                 ReportHub.LogError(ReportCategory.VERSION_CONTROL, "Failed to get launcher download URL.");
         }

Explorer/Assets/DCL/AuthenticationScreenFlow/AuthenticationScreenController.cs

@@ -52,7 +52,7 @@ public enum AuthStatus
 
         private readonly ICompositeWeb3Provider web3Authenticator;
         private readonly ISelfProfile selfProfile;
-        private readonly IWebBrowser webBrowser;
+        private readonly UnityAppWebBrowser webBrowser;
         private readonly IWeb3IdentityCache storedIdentityProvider;
         private readonly ICharacterPreviewFactory characterPreviewFactory;
         private readonly SplashScreen splashScreen;
@@ -99,7 +99,7 @@ public AuthenticationScreenController(
             ViewFactoryMethod viewFactory,
             ICompositeWeb3Provider web3Authenticator,
             ISelfProfile selfProfile,
-            IWebBrowser webBrowser,
+            UnityAppWebBrowser webBrowser,
             IWeb3IdentityCache storedIdentityProvider,
             ICharacterPreviewFactory characterPreviewFactory,
             SplashScreen splashScreen,
@@ -165,7 +165,7 @@ protected override void OnViewInstantiated()
                 new InitAuthState(viewInstance, installSource),
                 new LoginSelectionAuthState(fsm, viewInstance, this, CurrentState, splashScreen, web3Authenticator, webBrowser, enableEmailOTP),
                 new ProfileFetchingAuthState(fsm, viewInstance, this, CurrentState, selfProfile, storedIdentityProvider),
-                new IdentityVerificationDappAuthState(fsm, viewInstance, this, CurrentState, web3Authenticator),
+                new IdentityVerificationDappDeepLinkAuthState(fsm, viewInstance, this, CurrentState, web3Authenticator),
                 new LobbyForExistingAccountAuthState(fsm, viewInstance, this, splashScreen, CurrentState, characterPreviewController),
                 new LobbyForNewAccountAuthState(fsm, viewInstance, this, CurrentState, characterPreviewController, selfProfile, wearablesProvider, webBrowser, webRequestController, decentralandUrlsSource, profileChangesBus)
             );
@@ -212,7 +212,7 @@ private async UniTaskVoid TryAutoLoginAndProceedAsync(IWeb3Identity storedIdenti
                 bool autoLoginSuccess = await web3Authenticator.TryAutoLoginAsync(ct);
 
                 if (autoLoginSuccess)
-                    fsm.Enter<ProfileFetchingAuthState, ProfileFetchingPayload>(new (storedIdentity, storedIdentity.Source != IWeb3Identity.Web3IdentitySource.TokenFile, ct));
+                    fsm.Enter<ProfileFetchingAuthState, ProfileFetchingPayload>(new (storedIdentity, storedIdentity.Source != IWeb3Identity.Web3IdentitySource.TOKEN_FILE, ct));
                 else
                 {
                     fsm.Enter<LoginSelectionAuthState, int>(UIAnimationHashes.IN, true);
@@ -289,7 +289,7 @@ async UniTaskVoid ChangeAccountAsync(CancellationToken ct)
 
         private void OpenSupportUrl()
         {
-            webBrowser.OpenUrl(DecentralandUrl.SupportLink);
+            webBrowser.OpenUrlMainThreadOnly(DecentralandUrl.SupportLink);
             DiscordButtonClicked?.Invoke();
         }