fix: reenable saturation and value slider in backpack. (#7192)

alejandro-jimenez-dcl · web-flow · commit f1c53f01da0e · 2026-02-23T13:20:37.000+01:00
* fix: reenable saturation and value slider in backpack.
fix: use feature flag also for the processing of the color

* fix: update color processing

* tests: added feature flag initialization to failing tests
diff --git a/Explorer/Assets/DCL/Character/CharacterObject/Tests/CharacterTransformDirtyFlagShould.cs b/Explorer/Assets/DCL/Character/CharacterObject/Tests/CharacterTransformDirtyFlagShould.cs
diff --git a/Explorer/Assets/DCL/Multiplayer/SDK/Tests/PlayerCRDTEntitiesHandlerSystemShould.cs b/Explorer/Assets/DCL/Multiplayer/SDK/Tests/PlayerCRDTEntitiesHandlerSystemShould.cs
@@ -3,13 +3,15 @@
 using DCL.AvatarRendering.Emotes;
 using DCL.Character;
 using DCL.Character.Components;
+using DCL.FeatureFlags;
 using DCL.Multiplayer.SDK.Components;
 using DCL.Multiplayer.SDK.Systems.GlobalWorld;
 using DCL.PluginSystem.World;
 using DCL.Profiles;
 using ECS.LifeCycle.Components;
 using ECS.SceneLifeCycle;
 using ECS.TestSuite;
+using Global.AppArgs;
 using NSubstitute;
 using NUnit.Framework;
 using SceneRunner.Scene;
@@ -31,6 +33,21 @@ public class PlayerCRDTEntitiesHandlerSystemShould : UnitySystemTestBase<PlayerC
         private ISceneFacade scene1Facade;
         private ISceneFacade scene2Facade;
 
+        [OneTimeSetUp]
+        public void InitFF()
+        {
+            var appArgs = new ApplicationParametersParser();
+            FeatureFlagsConfiguration.Initialize(new FeatureFlagsConfiguration(FeatureFlagsResultDto.Empty));
+            FeaturesRegistry.Initialize(new FeaturesRegistry(appArgs, false));
+        }
+
+        [OneTimeTearDown]
+        public void ResetFF()
+        {
+            FeaturesRegistry.Reset();
+            FeatureFlagsConfiguration.Reset();
+        }
+
         [SetUp]
         public void Setup()
         {
diff --git a/Explorer/Assets/DCL/Multiplayer/SDK/Tests/PlayerProfileDataPropagationSystemShould.cs b/Explorer/Assets/DCL/Multiplayer/SDK/Tests/PlayerProfileDataPropagationSystemShould.cs
@@ -1,12 +1,14 @@
 using Arch.Core;
 using CRDT;
 using CrdtEcsBridge.Components;
+using DCL.FeatureFlags;
 using DCL.Multiplayer.SDK.Components;
 using DCL.Multiplayer.SDK.Systems.GlobalWorld;
 using DCL.Optimization.Pools;
 using DCL.PluginSystem.World;
 using DCL.Profiles;
 using ECS.TestSuite;
+using Global.AppArgs;
 using NSubstitute;
 using NUnit.Framework;
 using SceneRunner.Scene;
@@ -27,6 +29,21 @@ public class PlayerProfileDataPropagationSystemShould : UnitySystemTestBase<Play
         private PlayerCRDTEntity playerCRDTEntity;
         private CharacterDataPropagationUtility characterDataPropagationUtility;
 
+        [OneTimeSetUp]
+        public void InitFF()
+        {
+            var appArgs = new ApplicationParametersParser();
+            FeatureFlagsConfiguration.Initialize(new FeatureFlagsConfiguration(FeatureFlagsResultDto.Empty));
+            FeaturesRegistry.Initialize(new FeaturesRegistry(appArgs, false));
+        }
+
+        [OneTimeTearDown]
+        public void ResetFF()
+        {
+            FeatureFlagsConfiguration.Reset();
+            FeaturesRegistry.Reset();
+        }
+
         [SetUp]
         public void Setup()
         {
diff --git a/Explorer/Assets/DCL/Multiplayer/SDK/Tests/WriteAvatarEquippedDataSystemShould.cs b/Explorer/Assets/DCL/Multiplayer/SDK/Tests/WriteAvatarEquippedDataSystemShould.cs
@@ -4,10 +4,12 @@
 using DCL.AvatarRendering.Loading.Components;
 using DCL.AvatarRendering.Wearables.Helpers;
 using DCL.ECSComponents;
+using DCL.FeatureFlags;
 using DCL.Multiplayer.SDK.Components;
 using DCL.Profiles;
 using ECS.LifeCycle.Components;
 using ECS.TestSuite;
+using Global.AppArgs;
 using NSubstitute;
 using NUnit.Framework;
 using System;
@@ -31,6 +33,21 @@ private Avatar CreateTestAvatar() =>
                 WearablesConstants.DefaultColors.GetRandomHairColor(),
                 WearablesConstants.DefaultColors.GetRandomSkinColor());
 
+        [OneTimeSetUp]
+        public void InitFF()
+        {
+            var appArgs = new ApplicationParametersParser();
+            FeatureFlagsConfiguration.Initialize(new FeatureFlagsConfiguration(FeatureFlagsResultDto.Empty));
+            FeaturesRegistry.Initialize(new FeaturesRegistry(appArgs, false));
+        }
+
+        [OneTimeTearDown]
+        public void ResetFF()
+        {
+            FeaturesRegistry.Reset();
+            FeatureFlagsConfiguration.Reset();
+        }
+
         [SetUp]
         public void Setup()
         {
diff --git a/Explorer/Assets/DCL/Multiplayer/SDK/Tests/WritePlayerIdentityDataSystemShould.cs b/Explorer/Assets/DCL/Multiplayer/SDK/Tests/WritePlayerIdentityDataSystemShould.cs
@@ -2,10 +2,12 @@
 using CrdtEcsBridge.Components;
 using CrdtEcsBridge.ECSToCRDTWriter;
 using DCL.ECSComponents;
+using DCL.FeatureFlags;
 using DCL.Multiplayer.SDK.Components;
 using DCL.Profiles;
 using ECS.LifeCycle.Components;
 using ECS.TestSuite;
+using Global.AppArgs;
 using NSubstitute;
 using NUnit.Framework;
 using SceneRunner.Scene;
@@ -23,6 +25,21 @@ public class WritePlayerIdentityDataSystemShould : UnitySystemTestBase<WritePlay
         private SDKProfile profile;
         private PlayerSceneCRDTEntity playerCRDTEntity;
 
+        [OneTimeSetUp]
+        public void InitFF()
+        {
+            var appArgs = new ApplicationParametersParser();
+            FeatureFlagsConfiguration.Initialize(new FeatureFlagsConfiguration(FeatureFlagsResultDto.Empty));
+            FeaturesRegistry.Initialize(new FeaturesRegistry(appArgs, false));
+        }
+
+        [OneTimeTearDown]
+        public void ResetFF()
+        {
+            FeaturesRegistry.Reset();
+            FeatureFlagsConfiguration.Reset();
+        }
+
         [SetUp]
         public void Setup()
         {
diff --git a/Explorer/Assets/DCL/Multiplayer/SDK/Tests/WriteSDKAvatarBaseSystemShould.cs b/Explorer/Assets/DCL/Multiplayer/SDK/Tests/WriteSDKAvatarBaseSystemShould.cs
@@ -2,10 +2,12 @@
 using CrdtEcsBridge.Components;
 using CrdtEcsBridge.ECSToCRDTWriter;
 using DCL.ECSComponents;
+using DCL.FeatureFlags;
 using DCL.Multiplayer.SDK.Components;
 using DCL.Profiles;
 using ECS.LifeCycle.Components;
 using ECS.TestSuite;
+using Global.AppArgs;
 using NSubstitute;
 using NUnit.Framework;
 using System;
@@ -22,6 +24,21 @@ public class WriteSDKAvatarBaseSystemShould : UnitySystemTestBase<WriteSDKAvatar
         private SDKProfile profile;
         private PlayerSceneCRDTEntity playerCRDTEntity;
 
+        [OneTimeSetUp]
+        public void InitFF()
+        {
+            var appArgs = new ApplicationParametersParser();
+            FeatureFlagsConfiguration.Initialize(new FeatureFlagsConfiguration(FeatureFlagsResultDto.Empty));
+            FeaturesRegistry.Initialize(new FeaturesRegistry(appArgs, false));
+        }
+
+        [OneTimeTearDown]
+        public void ResetFF()
+        {
+            FeaturesRegistry.Reset();
+            FeatureFlagsConfiguration.Reset();
+        }
+
         [SetUp]
         public void Setup()
         {
diff --git a/Explorer/Assets/DCL/Passport/PassportController.cs b/Explorer/Assets/DCL/Passport/PassportController.cs
@@ -147,7 +147,6 @@ private enum OpenBadgeSectionOrigin
         private GenericContextMenuElement contextMenuBlockUserButton;
         private CommunityInvitationContextMenuButtonHandler invitationButtonHandler;
         private NameColorPickerController? colorPickerController;
-        private Color? userNameColorToSave;
 
         private UniTaskCompletionSource? contextMenuCloseTask;
         private UniTaskCompletionSource? passportCloseTask;
@@ -648,7 +647,6 @@ private async UniTaskVoid LoadPassportSectionAsync(string userId, PassportSectio
 
         private void SetNewUserNameColor(Color color)
         {
-            userNameColorToSave = color;
             UpdateBackgroundColor(color);
             UpdateUserNameTextColor(color);
         }
diff --git a/Explorer/Assets/DCL/Profiles/SharedAPI/Profile.CompactInfo.cs b/Explorer/Assets/DCL/Profiles/SharedAPI/Profile.CompactInfo.cs
@@ -1,5 +1,6 @@
 ﻿using CommunicationData.URLHelpers;
 using DCL.Diagnostics;
+using DCL.FeatureFlags;
 using DCL.Utilities;
 using DCL.Web3;
 using ECS.StreamableLoading.Common.Components;
@@ -131,7 +132,7 @@ public Color? ClaimedNameColor
                     }
 
                     claimedNameColor = value;
-                    if (value != null)
+                    if (FeaturesRegistry.Instance.IsEnabled(FeatureId.NAME_COLOR_CHANGE) && value is { a: > 0 })
                         UserNameColor = value.Value;
                 }
             }
@@ -261,7 +262,7 @@ private void GenerateAndValidateName()
                     MentionName = new string(mentionBuffer);
                 }
 
-                if (claimedNameColor.HasValue)
+                if (FeaturesRegistry.Instance.IsEnabled(FeatureId.NAME_COLOR_CHANGE) && claimedNameColor is { a: > 0 })
                     UserNameColor = claimedNameColor.Value;
                 else
                     UserNameColor = NameColorHelper.GetNameColor(DisplayName);
diff --git a/Explorer/Assets/DCL/Profiles/Tests/RealmProfileRepositoryShould.cs b/Explorer/Assets/DCL/Profiles/Tests/RealmProfileRepositoryShould.cs
@@ -2,12 +2,14 @@
 using Cysharp.Threading.Tasks;
 using DCL.AvatarRendering.Loading.Components;
 using DCL.DebugUtilities;
+using DCL.FeatureFlags;
 using DCL.Ipfs;
 using DCL.Multiplayer.Connections.DecentralandUrls;
 using DCL.PerformanceAndDiagnostics.Analytics;
 using DCL.Web3.Identities;
 using DCL.WebRequests;
 using ECS;
+using Global.AppArgs;
 using Newtonsoft.Json;
 using NSubstitute;
 using NUnit.Framework;
@@ -35,6 +37,21 @@ public class RealmProfileRepositoryShould
         // 19 profiles
         private List<Profile> dtos;
 
+        [OneTimeSetUp]
+        public void InitFF()
+        {
+            var appArgs = new ApplicationParametersParser();
+            FeatureFlagsConfiguration.Initialize(new FeatureFlagsConfiguration(FeatureFlagsResultDto.Empty));
+            FeaturesRegistry.Initialize(new FeaturesRegistry(appArgs, false));
+        }
+
+        [OneTimeTearDown]
+        public void ResetFF()
+        {
+            FeatureFlagsConfiguration.Reset();
+            FeaturesRegistry.Reset();
+        }
+
         [SetUp]
         public void SetUp()
         {
diff --git a/Explorer/Assets/DCL/SDKComponents/AvatarModifierArea/Tests/AvatarModifierAreaHandlerSystemShould.cs b/Explorer/Assets/DCL/SDKComponents/AvatarModifierArea/Tests/AvatarModifierAreaHandlerSystemShould.cs
@@ -5,6 +5,7 @@
 using DCL.AvatarRendering.Wearables.Helpers;
 using DCL.SDKEntityTriggerArea.Components;
 using DCL.ECSComponents;
+using DCL.FeatureFlags;
 using DCL.Profiles;
 using DCL.SceneRestrictionBusController.SceneRestrictionBus;
 using DCL.SDKComponents.AvatarModifierArea.Components;
@@ -14,6 +15,7 @@
 using ECS.Prioritization.Components;
 using ECS.TestSuite;
 using ECS.Unity.Transforms.Components;
+using Global.AppArgs;
 using NSubstitute;
 using NUnit.Framework;
 using System.Collections.Generic;
@@ -36,6 +38,21 @@ public class AvatarModifierAreaHandlerSystemShould : UnitySystemTestBase<AvatarM
         private GameObject fakeTriggerAreaGO;
         private SDKEntityTriggerArea.SDKEntityTriggerArea sdkEntityTriggerArea;
 
+        [OneTimeSetUp]
+        public void InitFF()
+        {
+            var appArgs = new ApplicationParametersParser();
+            FeatureFlagsConfiguration.Initialize(new FeatureFlagsConfiguration(FeatureFlagsResultDto.Empty));
+            FeaturesRegistry.Initialize(new FeaturesRegistry(appArgs, false));
+        }
+
+        [OneTimeTearDown]
+        public void ResetFF()
+        {
+            FeaturesRegistry.Reset();
+            FeatureFlagsConfiguration.Reset();
+        }
+
         [SetUp]
         public void Setup()
         {
diff --git a/Explorer/Assets/DCL/UI/ColorPicker/WearablesColorPickerController.cs b/Explorer/Assets/DCL/UI/ColorPicker/WearablesColorPickerController.cs
@@ -113,6 +113,8 @@ private void ShowColorPickerPopup()
                 InitialColor = initialColor,
                 ColorPresets = presets,
                 Position = anchorPosition,
+                EnableSaturationSlider = true,
+                EnableValueSlider = true,
                 OnColorChanged = (color) =>
                 {
                     UpdateColorPreviewImage(color);

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,6 @@ private enum OpenBadgeSectionOrigin`
`147`	`147`	`private GenericContextMenuElement contextMenuBlockUserButton;`
`148`	`148`	`private CommunityInvitationContextMenuButtonHandler invitationButtonHandler;`
`149`	`149`	`private NameColorPickerController? colorPickerController;`
`150`		`- private Color? userNameColorToSave;`
`151`	`150`
`152`	`151`	`private UniTaskCompletionSource? contextMenuCloseTask;`
`153`	`152`	`private UniTaskCompletionSource? passportCloseTask;`
`@@ -648,7 +647,6 @@ private async UniTaskVoid LoadPassportSectionAsync(string userId, PassportSectio`
`648`	`647`
`649`	`648`	`private void SetNewUserNameColor(Color color)`
`650`	`649`	`{`
`651`		`- userNameColorToSave = color;`
`652`	`650`	`UpdateBackgroundColor(color);`
`653`	`651`	`UpdateUserNameTextColor(color);`
`654`	`652`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`using CommunicationData.URLHelpers;`
`2`	`2`	`using DCL.Diagnostics;`
	`3`	`+using DCL.FeatureFlags;`
`3`	`4`	`using DCL.Utilities;`
`4`	`5`	`using DCL.Web3;`
`5`	`6`	`using ECS.StreamableLoading.Common.Components;`
`@@ -131,7 +132,7 @@ public Color? ClaimedNameColor`
`131`	`132`	`}`
`132`	`133`
`133`	`134`	`claimedNameColor = value;`
`134`		`- if (value != null)`
	`135`	`+ if (FeaturesRegistry.Instance.IsEnabled(FeatureId.NAME_COLOR_CHANGE) && value is { a: > 0 })`
`135`	`136`	`UserNameColor = value.Value;`
`136`	`137`	`}`
`137`	`138`	`}`
`@@ -261,7 +262,7 @@ private void GenerateAndValidateName()`
`261`	`262`	`MentionName = new string(mentionBuffer);`
`262`	`263`	`}`
`263`	`264`
`264`		`- if (claimedNameColor.HasValue)`
	`265`	`+ if (FeaturesRegistry.Instance.IsEnabled(FeatureId.NAME_COLOR_CHANGE) && claimedNameColor is { a: > 0 })`
`265`	`266`	`UserNameColor = claimedNameColor.Value;`
`266`	`267`	`else`
`267`	`268`	`UserNameColor = NameColorHelper.GetNameColor(DisplayName);`