-
Notifications
You must be signed in to change notification settings - Fork 14
Closed
Labels
2-mediumAffects secondary features or support features; doesn’t block main flows.Affects secondary features or support features; doesn’t block main flows.bugSomething isn't workingSomething isn't working
Description
🛠️ Build version:
feat/clearscript-7?5
📔 Issue Description:
Various disk cache code, LRUDiskCleanUp in particular, allocates too much memory too often. Calculation of file paths allocates a small amount, but it is called around 300 times, and it adds up. Another example is hash calculations that allocate 20 KB per frame in which disk cache is used.
👣 STR:
- Spawn into the game
- Wait for allocation spikes in the profiler. They come once every second or so
✔️ Expected Result:
Zero allocations, lol! Okay, as few allocations as possible, and there are comments in the code for the cases that could not be optimized to zero.
❌ Actual Result with evidence:
➗ Reproduction:
🔁 Always - (note)
The code allocates every time it runs.
🖥️ Operative system and additional Notes:
Windows 10
Metadata
Metadata
Assignees
Labels
2-mediumAffects secondary features or support features; doesn’t block main flows.Affects secondary features or support features; doesn’t block main flows.bugSomething isn't workingSomething isn't working
Type
Projects
Status
Done