Allow passing ErrorFallback for frameworks (#930)

Signed-off-by: Marcos Candeia <marrcooos@gmail.com>

Author: mcandeia

.github/workflows/releaser.yaml

@@ -179,4 +179,4 @@ jobs:
               -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \
               -H "Accept: application/vnd.github.everest-preview+json" \
               https://api.github.com/repos/${{ github.repository }}/actions/workflows/publish.yaml/dispatches \
-              -d '{"ref":"main", "inputs":{"tag_name":"${{ steps.determine_version.outputs.new_version }}"}}'
+              -d '{"ref":"main", "inputs":{"tag_name":"${{ steps.determine_version.outputs.new_version }}"}}'

README.md

@@ -1,6 +1,6 @@
 <p align="center">
   <img src="https://github.com/deco-cx/deco/assets/1633518/ba714da8-514e-4b48-bbec-b7d86377b273" alt="deco" width="210px"/>
-</p> 
+</p>
 <p align="center">
   <strong>Git-based Visual CMS for Deno, &lt;/>htmx and Tailwind Apps.</strong>
 </p>

blocks/loader.ts

@@ -15,7 +15,7 @@ import {
   OTEL_ENABLE_EXTRA_METRICS,
 } from "../observability/otel/metrics.ts";
 import { caches, ENABLE_LOADER_CACHE } from "../runtime/caches/mod.ts";
-import { DebugProperties } from "../utils/vary.ts";
+import type { DebugProperties } from "../utils/vary.ts";
 import type { HttpContext } from "./handler.ts";
 import {
   applyProps,

runtime/fresh/plugin.tsx

@@ -1,12 +1,12 @@
 // TODO make fresh plugin use @deco/deco from JSR. so that we can use the same code for both
 
-import type { AppManifest, DecoContext, SiteInfo } from "@deco/deco";
+import type { Plugin } from "$fresh/server.ts";
+import type { AppManifest, DecoContext, Framework, SiteInfo } from "@deco/deco";
 import { Deco, type PageData, type PageParams } from "@deco/deco";
 import { framework as htmxFramework } from "@deco/deco/htmx";
 import type { ComponentType } from "preact";
-import framework from "./Bindings.tsx";
-import type { Plugin } from "$fresh/server.ts";
 import type { Bindings } from "../handler.tsx";
+import freshFramework from "./Bindings.tsx";
 export type { Plugin } from "$fresh/server.ts";
 
 export interface PluginRoute {
@@ -51,6 +51,7 @@ export interface InitOptions<TManifest extends AppManifest = AppManifest> {
   htmx?: boolean;
   site?: SiteInfo;
   deco?: Deco<TManifest>;
+  ErrorFallback?: Framework["ErrorFallback"];
   useServer?: Bindings<TManifest>["useServer"];
   middlewares?: PluginMiddleware[];
   visibilityOverrides?: DecoContext<TManifest>["visibilityOverrides"];
@@ -87,12 +88,17 @@ export default function decoPlugin<TManifest extends AppManifest = AppManifest>(
     throw new Error(`functions opts are not supported`);
   }
 
+  const framework = opt?.htmx ? htmxFramework : freshFramework;
+
   const decoPromise = opt.deco instanceof Deco ? opt.deco : Deco.init({
     manifest: opt.manifest,
     site: opt?.site?.name,
     namespace: opt?.site?.namespace,
     bindings: {
-      framework: opt?.htmx ? htmxFramework : framework,
+      framework: {
+        ...framework,
+        ErrorFallback: opt.ErrorFallback ?? framework.ErrorFallback,
+      },
       useServer: opt?.useServer,
     },
     visibilityOverrides: opt.visibilityOverrides,