fix(observability): vendor incubating semconv consts + correct service.version

- Stop re-exporting from @opentelemetry/semantic-conventions/incubating (OTel
  advises against depending on the unstable entry point); vendor the 4 needed
  experimental attribute names as plain constants in conventions.ts.
- service.version: use the deployment revision (deploymentId) falling back to
  the framework version, not Deno.hostname() (which is instance identity).

Addresses PR review (cubic P2 + coderabbit). Cache is already a single
deco.cache.requests counter + deco.cache.status label (earlier commit).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: nicacioliveira

deps.ts

@@ -89,14 +89,10 @@ export {
   ATTR_USER_AGENT_ORIGINAL,
   METRIC_HTTP_SERVER_REQUEST_DURATION,
 } from "npm:@opentelemetry/semantic-conventions@1.37.0";
-// Incubating (not yet stable) semantic conventions.
-export {
-  ATTR_CLOUD_PROVIDER,
-  ATTR_CLOUD_REGION,
-  ATTR_DEPLOYMENT_ENVIRONMENT_NAME,
-  ATTR_HTTP_REQUEST_BODY_SIZE,
-  ATTR_SERVICE_INSTANCE_ID,
-} from "npm:@opentelemetry/semantic-conventions@1.37.0/incubating";
+// Incubating (experimental) semconv names are NOT re-exported here — OTel
+// advises libraries against depending on the unstable `/incubating` entry
+// point. The few we need are vendored as plain constants in
+// observability/otel/conventions.ts.
 
 export {
   ExplicitBucketHistogramAggregation,

observability/otel/config.ts

@@ -3,10 +3,6 @@ import { Logger } from "@std/log/logger";
 import { Context, context } from "../../deco.ts";
 import denoJSON from "../../deno.json" with { type: "json" };
 import {
-  ATTR_CLOUD_PROVIDER,
-  ATTR_CLOUD_REGION,
-  ATTR_DEPLOYMENT_ENVIRONMENT_NAME,
-  ATTR_SERVICE_INSTANCE_ID,
   ATTR_SERVICE_NAME,
   ATTR_SERVICE_VERSION,
   BatchSpanProcessor,
@@ -18,6 +14,12 @@ import {
   registerInstrumentations,
   Resource,
 } from "../../deps.ts";
+import {
+  ATTR_CLOUD_PROVIDER,
+  ATTR_CLOUD_REGION,
+  ATTR_DEPLOYMENT_ENVIRONMENT_NAME,
+  ATTR_SERVICE_INSTANCE_ID,
+} from "./conventions.ts";
 import { DenoRuntimeInstrumentation } from "./instrumentation/deno-runtime.ts";
 import { DebugSampler } from "./samplers/debug.ts";
 import { type SamplingOptions, URLBasedSampler } from "./samplers/urlBased.ts";
@@ -40,7 +42,9 @@ const apps_ver = tryGetVersionOf("apps/") ??
 export const resource = Resource.default().merge(
   new Resource({
     [ATTR_SERVICE_NAME]: Deno.env.get(ENV_SITE_NAME) ?? "deco",
-    [ATTR_SERVICE_VERSION]: Context.active().deploymentId ?? Deno.hostname(),
+    // Version of the deployed artifact (the deployment revision), falling back
+    // to the framework version — NOT the hostname (that is instance identity).
+    [ATTR_SERVICE_VERSION]: Context.active().deploymentId ?? denoJSON.version,
     [ATTR_SERVICE_INSTANCE_ID]: crypto.randomUUID(),
     [ATTR_CLOUD_PROVIDER]: context.platform,
     "deco.runtime.version": denoJSON.version,

observability/otel/conventions.ts

@@ -18,3 +18,12 @@ export const ATTR_DECO_OPERATION_ERROR = "deco.operation.error";
 export const ATTR_DECO_CACHE_ENGINE = "deco.cache.engine";
 // Cache outcome: hit | stale | miss (| bypass). Same key on span + metric.
 export const ATTR_DECO_CACHE_STATUS = "deco.cache.status";
+
+// Vendored copies of EXPERIMENTAL (incubating) OTel semconv attribute names.
+// OTel recommends libraries NOT import from `@opentelemetry/.../incubating`
+// (the entry point is unstable across versions); copy the values instead.
+// Sourced from @opentelemetry/semantic-conventions 1.37.0/incubating.
+export const ATTR_CLOUD_PROVIDER = "cloud.provider";
+export const ATTR_CLOUD_REGION = "cloud.region";
+export const ATTR_DEPLOYMENT_ENVIRONMENT_NAME = "deployment.environment.name";
+export const ATTR_SERVICE_INSTANCE_ID = "service.instance.id";