Skip to content

Commit 9ed25c3

Browse files
fix(bench): drop esm.sh dts for object-hash to unbreak CI type-check
The object-hash bench import pulled @types/object-hash via esm.sh, whose CommonJS `export =` (no synthetic default) makes a fresh Deno type-check fail with TS1192 — turning main red regardless of the PR. The types aren't used in the benchmark, so `?no-dts` drops them and keeps CI deterministic. Verified: `deno check --reload` passes and the benchmark still runs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 6885b71 commit 9ed25c3

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

blocks/loader.bench.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
import hash from "https://esm.sh/v135/object-hash@3.0.0";
1+
// `?no-dts` skips esm.sh's bundled type definitions. Upstream `@types/object-hash`
2+
// uses a CommonJS `export =` with no synthetic default, which makes Deno's
3+
// type-check fail with TS1192 ("no default export") on a fresh fetch. The types
4+
// aren't needed in this benchmark, so dropping them keeps CI deterministic.
5+
import hash from "https://esm.sh/v135/object-hash@3.0.0?no-dts";
26

37
const props = {
48
randomObject: {

0 commit comments

Comments
 (0)