build: golangci-lint v2.7.2

Author: dajohi

.github/workflows/docker.yml

@@ -8,7 +8,7 @@ jobs:
     name: Dockerfile build
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac #v4.0.0
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - name: Build the Docker image
         run: docker build -t decred/dcrlnd:$(date +%s) .
 

.github/workflows/go.yml

@@ -12,15 +12,18 @@ jobs:
         go: ['1.24', '1.25']
     steps:
       - name: Set up Go
-        uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 #5.5.0
+        uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
         with:
           go-version: ${{ matrix.go }}
 
       - name: Check out source
         uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #v5.0.0
 
-      - name: Install Linters
-        run: "go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.8"
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@0a35821d5c230e903fcfe077583637dea1b27b47 # v9.0.0
+        with:
+          install-mode: "goinstall"
+          version: 9f61b0f53f80672872fced07b6874397c3ed197b # v2.7.2
 
       - name: Check golangci-lint version
         run: golangci-lint --version
@@ -30,7 +33,7 @@ jobs:
 
       - name: Lint
         run: |
-          golangci-lint run --out-format=github-actions
+          golangci-lint run
 
       - name: Package test binaries
         run: |
@@ -60,7 +63,7 @@ jobs:
           - itest-parallel-run walletimpl=remotewallet backend=spv # remote wallet spv sync
     steps:
       - name: Set up Go
-        uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 #5.5.0
+        uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
         with:
           go-version: ${{ matrix.go }}
 

.golangci.yml

@@ -1,57 +1,29 @@
+version: "2"
 run:
-  deadline: 10m
-
+  timeout: 10m
 linters:
-  # Skip autogenerated files for mobile and gRPC.
-  skip-files:
-    - "mobile\\/.*generated\\.go"
-    - "\\.pb\\.go$"
-    - "\\.pb\\.gw\\.go$"
-
-  disable-all: true
+  default: none
   enable:
     - asciicheck
     - bidichk
     - bodyclose
     - errchkjson
-#    - exportloopref
-    - gofmt
-    - gosimple
     - govet
     - grouper
     - ineffassign
     - nosprintfhostport
     - reassign
     - rowserrcheck
-    - typecheck
     - unconvert
     - unused
-    - vetshadow
-
-issues:
-  # Only show newly introduced problems.
-  # new-from-rev: 01f696afce2f9c0d4ed854edefa3846891d01d8a
-
-  exclude-rules:
-    # Exclude gosec from running for tests so that tests with weak randomness
-    # (math/rand) will pass the linter.
-    - path: _test\.go
-      linters:
-        - gosec
-
-    # Fix false positives because of build flags in itest directory.
-    - path: lntest/itest/.*
-      linters:
-        - unused
-        - deadcode
-        - unparam
-        - govet
-
-    # Ignore govet.lostcancel in integration test files. The
-    # integration tests make substantial use of context.WithTimeout()
-    # without corresponding cancel() calls, which trigger this. So
-    # disable these warnings for now until this is fixed upstream
-    # (otherwise merging upstream itest changes will become
-    # significantly harder)
-    - path: lntest/
-      text: lostcancel
+  exclusions:
+    rules:
+      - linters:
+          - govet
+          - unused
+        path: lntest/itest/.*
+      - path: lntest/
+        text: lostcancel
+formatters:
+  enable:
+    - gofmt

build/deployment_dev.go

@@ -1,5 +1,4 @@
 //go:build dev
-// +build dev
 
 package build
 

build/deployment_prod.go

@@ -1,5 +1,4 @@
 //go:build !dev
-// +build !dev
 
 package build
 

build/log_default.go

@@ -1,5 +1,4 @@
 //go:build !stdlog && !nolog && !filelog
-// +build !stdlog,!nolog,!filelog
 
 package build
 

build/log_filelog.go

@@ -1,5 +1,4 @@
 //go:build filelog
-// +build filelog
 
 package build
 

build/log_nolog.go

@@ -1,5 +1,4 @@
 //go:build nolog
-// +build nolog
 
 package build
 

build/log_stdlog.go

@@ -1,5 +1,4 @@
 //go:build stdlog
-// +build stdlog
 
 package build
 

build/loglevel_critical.go

@@ -1,5 +1,4 @@
 //go:build dev && critical
-// +build dev,critical
 
 package build