Merge pull request #586 from dedis/dkg/synctest

Use synctest instead of fakeclock in tests

Author: jbsv

go.mod

@@ -1,11 +1,10 @@
 module go.dedis.ch/kyber/v4
 
-go 1.25.0
+go 1.25
 
 require (
 	github.com/cloudflare/circl v1.6.1
 	github.com/consensys/gnark-crypto v0.19.2
-	github.com/jonboulle/clockwork v0.5.0
 	github.com/kilic/bls12-381 v0.1.0
 	github.com/stretchr/testify v1.11.1
 	go.dedis.ch/fixbuf v1.0.3

go.sum

@@ -7,8 +7,6 @@ github.com/consensys/gnark-crypto v0.19.2/go.mod h1:rT23F0XSZqE0mUA0+pRtnL56IbPx
 github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
-github.com/jonboulle/clockwork v0.5.0 h1:Hyh9A8u51kptdkR+cqRpT1EebBwTn1oK9YfGYbdFz6I=
-github.com/jonboulle/clockwork v0.5.0/go.mod h1:3mZlmanh0g2NDKO5TWZVJAfofYk64M7XN3SzBPjZF60=
 github.com/kilic/bls12-381 v0.1.0 h1:encrdjqKMEvabVQ7qYOKu1OvhqpK4s47wDYtNiPtlp4=
 github.com/kilic/bls12-381 v0.1.0/go.mod h1:vDTTHJONJ6G+P2R74EhnyotQDTliQDnFEwhdmfzw1ig=
 github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=

share/dkg/pedersen/dkg_test.go

@@ -3,11 +3,11 @@ package dkg
 import (
 	"errors"
 	"fmt"
-	"math/rand"
+	"math/rand/v2"
 	"testing"
 
-	clock "github.com/jonboulle/clockwork"
 	"github.com/stretchr/testify/require"
+
 	"go.dedis.ch/kyber/v4"
 	"go.dedis.ch/kyber/v4/group/edwards25519"
 	"go.dedis.ch/kyber/v4/share"
@@ -24,7 +24,6 @@ type TestNode struct {
 	proto   *Protocol
 	phaser  *TimePhaser
 	board   *TestBoard
-	clock   *clock.FakeClock
 }
 
 func NewTestNode(s Suite, index uint32) *TestNode {
@@ -212,7 +211,7 @@ func TestSelfEvictionDealer(t *testing.T) {
 	thr := uint32(3)
 	suite := edwards25519.NewBlakeSHA256Ed25519()
 	tns := GenerateTestNodes(suite, n)
-	skippedIndex := rand.Intn(int(n))
+	skippedIndex := rand.IntN(int(n))
 	var newIndex uint32 = 53 // XXX should there be a limit to the index ?
 	tns[skippedIndex].Index = newIndex
 	list := NodesFromTest(tns)
@@ -290,9 +289,9 @@ func TestDKGSkipIndex(t *testing.T) {
 	newT := thr + nodesToAdd - 1 // set the threshold to accept one offline new node
 	var newTns = make([]*TestNode, 0, newN)
 	// remove a random node from the previous group
-	offlineToRemove := uint32(rand.Intn(int(n)))
+	offlineToRemove := rand.IntN(int(n))
 	for i, node := range tns {
-		if i == int(offlineToRemove) {
+		if i == offlineToRemove {
 			continue
 		}
 		newTns = append(newTns, node)