fix: resolve Windows GBK encoding issue in CLI output#472
Open
fanghuaqi wants to merge 1 commit into
Open
Conversation
- Set stdout/stderr to UTF-8 encoding in safe_entry_point() - Fixes UnicodeEncodeError when output contains special Unicode characters (e.g., Arabic characters, Chinese characters, trademark symbols) - Only applies on Windows when sys.stdout.reconfigure() is available - Add test case for extract command
af728b2 to
b317e2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes UnicodeEncodeError when running ddgs CLI commands on Windows with GBK console encoding.
Changes
safe_entry_point()sys.stdout.reconfigure()is availableProblem
On Windows, the default console encoding is GBK. When ddgs CLI outputs results containing characters that can't be encoded in GBK (like Arabic characters, Chinese characters, or special symbols), it crashes with:
Solution
Instead of adding exception handling to every
click.secho()call, we set the stdout/stderr encoding to UTF-8 at the program entry point insafe_entry_point(). This is a cleaner, more comprehensive solution that:reconfigure()is not availableTesting
test_extract_commandtest case