Merge pull request #1924 from lat-lon/fix/improvedErrorHandlingConsole-870

Improved logging in case of errors in deegree admin console

Author: copierrj

deegree-services/deegree-webservices/src/main/java/org/deegree/console/metadata/ResourceManagerMetadata.java

@@ -73,6 +73,9 @@ public class ResourceManagerMetadata implements Comparable<ResourceManagerMetada
 	private final Workspace workspace;
 
 	private ResourceManagerMetadata(ResourceManager<?> mgr, Workspace workspace) {
+		if (mgr == null)
+			throw new IllegalArgumentException(
+					"ResourceManager must not be null. Check your workspace configuration for errors.");
 		this.workspace = workspace;
 		if (mgr.getMetadata() != null) {
 			for (ResourceProvider<?> provider : mgr.getProviders()) {

deegree-services/deegree-webservices/src/main/java/org/deegree/console/workspace/WorkspaceBean.java

@@ -217,7 +217,7 @@ public String applyChanges() {
 			OGCFrontController.getInstance().reload();
 		}
 		catch (Exception e) {
-			e.printStackTrace();
+			LOG.error("Failed to reload OGCFrontController {} ", e.getMessage(), e);
 		}
 
 		modified = false;
@@ -240,6 +240,7 @@ public void downloadWorkspace() {
 			importWorkspace(location);
 		}
 		catch (Throwable t) {
+			LOG.error("Failed to download workspace {} ", t.getMessage(), t);
 			FacesMessage fm = new FacesMessage(SEVERITY_ERROR, "Unable to download workspace: " + t.getMessage(), null);
 			FacesContext.getCurrentInstance().addMessage(null, fm);
 		}
@@ -274,7 +275,7 @@ private void importWorkspace(String location) {
 			}
 		}
 		catch (Exception e) {
-			e.printStackTrace();
+			LOG.error("Failed to import workspace {} ", e.getMessage(), e);
 			FacesMessage fm = new FacesMessage(SEVERITY_ERROR, "Unable to import workspace: " + e.getMessage(), null);
 			FacesContext.getCurrentInstance().addMessage(null, fm);
 		}
@@ -363,7 +364,7 @@ public List<String> downloadWorkspaceList(String url) {
 			return res;
 		}
 		catch (Throwable t) {
-			LOG.warn("Could not get workspace list: {}.", t.getMessage());
+			LOG.error("Could not get workspace list: {}.", t.getMessage());
 			return new ArrayList<String>();
 		}
 		finally {