build: Solve the version error #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5694bc7.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #354 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 40 40
Lines 980 980
=======================================
Hits 968 968
Misses 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build process was not working properly anymore. The
__version__attribute was not picked up: the lineversion = attr: ruptures.__version__insetup.cfgfile fails with aModuleNotFoundError.Related issues/PR:
version = attr: pkg.__version__in setup.cfg pypa/setuptools#1724 (in particular this answer)I'm not sure why this is a problem only now.
My workaround is to remove the culprit line that was causing the error:
The version is correctly picked up from
ruptures/version.py. However this is an implicit behaviour and I haven't found any documentation on it. Maybe not the best mechanism, so I'm open to suggestions.This should solve #351 #353
This PR also adds an option to prevent uploading wheels and dist to PyPI. This way we can build wheels and dist (for Python 3.13 for instance) and upload them manually to PyPI without incrementing the version.