-
Notifications
You must be signed in to change notification settings - Fork 173
ci(upload-pypi): bump versions of gha and manage supported python versions #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 40 40
Lines 980 980
=======================================
Hits 968 968
Misses 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
An error is thrown when uploading an artefact (`actions/upload-artifact`) because the version is too old https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
Build wheels on ubuntu-latest cibuildwheel: Invalid skip selector: 'pp*'. This selector matches a group that wasn't enabled. Enable it using the `enable` option or remove this selector. This selector will have no effect.
Warning: cibuildwheel 3 will require Python 3.11+, please upgrade the Python version used to run cibuildwheel. This does not affect the versions you can target when building wheels. See: https://cibuildwheel.pypa.io/en/stable/#what-does-it-do
I mean, why not?
because one wheel is bugging on python 3.8 and win amd64
cd3bdae to
0ef139d
Compare
|
well that was painful. In sumary,
Once this gets merged, I'll finally be able to generate new wheels |
dudustri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job 👍
| strategy: | ||
| matrix: | ||
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] | ||
| python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(question): no 3.14 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ! 332fc31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately, there is no simple way to test ruptures on py3.14. The gh action running the tests raises this error:
Error: The version '3.14' with architecture 'x64' was not found for Ubuntu 24.04.
I'd rather not publish untested code, so I'll remove support for py3.14 for now.
Sorry for the noise
An error is thrown when uploading an artefact (
actions/upload-artifact) because the version is too oldhttps://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
Edit
Everything broke after bumping the version, so I ended up changing more things.
Summary of changes:
setup.cfg(there was an error when installing scipy for py37 on win_amd64)actions/upload-artifact, and giving a specific name for each artifact to avoid name collisionMy changes are mostly based on this guide