Skip to content

Auto-complete on instance should not suggest static methods #875

Open
@devinrsmith

Description

@devinrsmith

I added a new static method on io.deephaven.db.tables.Table. This is causing the following test to fail:

Condition not satisfied:

results.size() == 0
|       |      |
|       1      false
[
t = emptyTable(10)
u = t.of(]

	at io.deephaven.lang.completion.ChunkerCompletionHandlerTest.Methods on binding variables that were assigned a value from an emptyTable method returning Table will know it is a table(ChunkerCompletionHandlerTest.groovy:118)

From James: "there never used to be static methods on table, so I think it simply was not exercised properly"

           if (Modifier.isPublic(method.getModifiers())) {
                // TODO we'll likely want to pick between static or instance methods, based on calling scope.
                //   IDS-1517-19
                if (camelMatch(method.getName(), methodPrefix)) {
                    sorter.add(method.getName(), method);
                }
            }

Note: the property ChunkerCompleter.PROP_SUGGEST_STATIC_METHODS is only for statically imported static methods, and not relevant to this issue at hand on an instance.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions