refactor(rhog_io): remove PARAM dependency, pass nspin as parameter

- Add explicit nspin parameter to read_rhog() signature, making it
  consistent with write_rhog() which already has nspin
- Remove #include of parameter.h and global_variable.h from rhog_io.cpp
  - No longer reads PARAM.inp.nspin anywhere
- Update charge_init.cpp call sites to pass the existing local nspin var
- Remove dead PARAM.input.nspin assignments and #define private public
  hack from read_rhog_test.cpp (rhog_io no longer consumes PARAM)

Author: abacus_fixer

source/source_estate/module_charge/charge_init.cpp

@@ -55,7 +55,7 @@ void Charge::init_rho(const UnitCell& ucell,
         binary << PARAM.globalv.global_readin_dir << PARAM.inp.suffix + "-CHARGE-DENSITY.restart";
         // Temporary bridge: use factory until ParaCollection is wired into driver.
         Parallel::ParaWorld pw_world = Parallel::make_pw_world();
-        if (ModuleIO::read_rhog(binary.str(), rhopw, rhog, pw_world))
+        if (ModuleIO::read_rhog(binary.str(), rhopw, nspin, rhog, pw_world))
         {
             GlobalV::ofs_running << " Read electron density from file: " << binary.str() << std::endl;
             for (int is = 0; is < nspin; ++is)
@@ -152,7 +152,7 @@ void Charge::init_rho(const UnitCell& ucell,
 
                 std::stringstream binary;
                 binary << PARAM.globalv.global_readin_dir << PARAM.inp.suffix + "-TAU-DENSITY.restart";
-                if (ModuleIO::read_rhog(binary.str(), rhopw, kin_g.data(), pw_world))
+                if (ModuleIO::read_rhog(binary.str(), rhopw, nspin, kin_g.data(), pw_world))
                 {
                     GlobalV::ofs_running << " Read in the kinetic energy density: " << binary.str() << std::endl;
                     for (int is = 0; is < nspin; ++is)

source/source_io/module_chgpot/rhog_io.cpp

@@ -1,7 +1,5 @@
 #include "source_base/module_out/binstream.h"
 #include "source_base/global_function.h"
-#include "source_io/module_parameter/parameter.h"
-#include "source_base/global_variable.h"
 #include "source_base/timer.h"
 #include "source_base/vector3.h"
 #include "source_base/module_parallel/para_mpi_func.h"
@@ -11,6 +9,7 @@
 
 bool ModuleIO::read_rhog(const std::string& filename,
                          const ModulePW::PW_Basis* pw_rhod,
+                         const int nspin,
                          std::complex<double>** rhog,
                          const Parallel::ParaWorld& pw_world)
 {
@@ -66,7 +65,7 @@ bool ModuleIO::read_rhog(const std::string& filename,
         {
             ModuleBase::WARNING("ModuleIO::read_rhog", "some planewaves in file are missing");
         }
-        if (nspin_in < PARAM.inp.nspin)
+        if (nspin_in < nspin)
         {
             ModuleBase::WARNING("ModuleIO::read_rhog", "some spin channels in file are missing");
         }
@@ -105,7 +104,7 @@ bool ModuleIO::read_rhog(const std::string& filename,
     Parallel::bcast_int(miller.data(), miller.size(), pw_world);
 
     // set to zero
-    for (int is = 0; is < PARAM.inp.nspin; ++is)
+    for (int is = 0; is < nspin; ++is)
     {
         ModuleBase::GlobalFunc::ZEROS(rhog[is], pw_rhod->npw);
     }
@@ -162,7 +161,7 @@ bool ModuleIO::read_rhog(const std::string& filename,
             }
         }
 
-        if (nspin_in == 2 && PARAM.inp.nspin == 4 && is == 1)
+        if (nspin_in == 2 && nspin == 4 && is == 1)
         {
             for (int ig = 0; ig < pw_rhod->npw; ++ig)
             {

source/source_io/module_chgpot/rhog_io.h

@@ -46,6 +46,7 @@ namespace ModuleIO
 
 bool read_rhog(const std::string& filename,
                const ModulePW::PW_Basis* pw_rhod,
+               const int nspin,
                std::complex<double>** rhog,
                const Parallel::ParaWorld& pw_world);
 

source/source_io/test/read_rhog_test.cpp

@@ -1,8 +1,5 @@
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"
-#define private public
-#include "source_io/module_parameter/parameter.h"
-#undef private
 #include "source_io/module_chgpot/rhog_io.h"
 #include "source_base/module_parallel/para_world.h"
 #include "source_base/module_parallel/para_tag.h"
@@ -48,7 +45,6 @@ class ReadRhogTest : public ::testing::Test
 TEST_F(ReadRhogTest, ReadRhog)
 {
     std::string filename = "./support/charge-density.dat";
-    PARAM.input.nspin = 1;
 #ifdef __MPI
     rhopw->initmpi(GlobalV::NPROC_IN_POOL, GlobalV::RANK_IN_POOL, MPI_COMM_WORLD);
 #endif
@@ -57,7 +53,7 @@ TEST_F(ReadRhogTest, ReadRhog)
     rhopw->setuptransform();
     rhopw->collect_local_pw();
 
-    bool result = ModuleIO::read_rhog(filename, rhopw, rhog, pw_world);
+    bool result = ModuleIO::read_rhog(filename, rhopw, 1, rhog, pw_world);
 
     EXPECT_TRUE(result);
     EXPECT_DOUBLE_EQ(rhog[0][0].real(), -1.0304462993299456e-05);
@@ -74,7 +70,7 @@ TEST_F(ReadRhogTest, NotFoundFile)
     std::string filename = "notfound.txt";
 
     GlobalV::ofs_warning.open("test_read_rhog.txt");
-    bool result = ModuleIO::read_rhog(filename, rhopw, rhog, pw_world);
+    bool result = ModuleIO::read_rhog(filename, rhopw, 1, rhog, pw_world);
     GlobalV::ofs_warning.close();
 
     std::ifstream ifs_running("test_read_rhog.txt");
@@ -94,11 +90,10 @@ TEST_F(ReadRhogTest, NotFoundFile)
 TEST_F(ReadRhogTest, InconsistentGammaOnly)
 {
     std::string filename = "./support/charge-density.dat";
-    PARAM.input.nspin = 2;
     rhopw->gamma_only = true;
 
     GlobalV::ofs_warning.open("test_read_rhog.txt");
-    bool result = ModuleIO::read_rhog(filename, rhopw, rhog, pw_world);
+    bool result = ModuleIO::read_rhog(filename, rhopw, 2, rhog, pw_world);
     GlobalV::ofs_warning.close();
 
     std::ifstream ifs_running("test_read_rhog.txt");
@@ -121,11 +116,10 @@ TEST_F(ReadRhogTest, InconsistentGammaOnly)
 TEST_F(ReadRhogTest, SomePWMissing)
 {
     std::string filename = "./support/charge-density.dat";
-    PARAM.input.nspin = 1;
     rhopw->npwtot = 2000;
 
     GlobalV::ofs_warning.open("test_read_rhog.txt");
-    bool result = ModuleIO::read_rhog(filename, rhopw, rhog, pw_world);
+    bool result = ModuleIO::read_rhog(filename, rhopw, 1, rhog, pw_world);
     GlobalV::ofs_warning.close();
 
     std::ifstream ifs_running("test_read_rhog.txt");