refactor(klist): pass my_rank/my_pool into mpi_k

Remove the GlobalV::MY_RANK/MY_POOL dependency from K_Vectors::mpi_k by
taking them as parameters; the single caller (set()) passes the GlobalV
values. Private signature only, no public interface change.
global_dependency count in klist.cpp drops by 5.

Verified: cmake --build build_max_para_test -j30 (exit 0, __MPI on) and
ctest -R "MODULE_CELL_(klist|reciprocal_grid|qlist)" -> 5/5.

Author: abacus_fixer

source/source_cell/klist.cpp

@@ -174,7 +174,7 @@ void K_Vectors::set(const UnitCell& ucell,
                        nspin_in); // assign k points to several process pools
 #ifdef __MPI
     // distribute K point data to the corresponding process
-    this->mpi_k(ofs);
+    this->mpi_k(ofs, GlobalV::MY_RANK, GlobalV::MY_POOL);
 #endif
 
     // set the k vectors for the up and down spin
@@ -681,7 +681,7 @@ void K_Vectors::set_after_vc(const ModuleBase::Matrix3& G, std::ofstream& ofs_ru
 }
 
 #ifdef __MPI
-void K_Vectors::mpi_k(std::ofstream& ofs_running)
+void K_Vectors::mpi_k(std::ofstream& ofs_running, const int my_rank, const int my_pool)
 {
     ModuleBase::TITLE("K_Vectors", "mpi_k");
 
@@ -702,7 +702,7 @@ void K_Vectors::mpi_k(std::ofstream& ofs_running)
 
     Parallel_Common::bcast_double(this->koffset, 3);
 
-    this->nks = this->para_k.nks_pool[GlobalV::MY_POOL];
+    this->nks = this->para_k.nks_pool[my_pool];
 
     ofs_running << std::endl;
     ModuleBase::GlobalFunc::OUT(ofs_running, "Number of k-points in this process", this->nks);
@@ -726,7 +726,7 @@ void K_Vectors::mpi_k(std::ofstream& ofs_running)
     std::vector<double> kvec_c_full_aux(this->nkstot_full * 3);
 
     // collect and process in rank 0
-    if (GlobalV::MY_RANK == 0)
+    if (my_rank == 0)
     {
         KListIO::pack_kpts(this->isk,
                            this->wk,
@@ -759,7 +759,7 @@ void K_Vectors::mpi_k(std::ofstream& ofs_running)
                          kvec_d_aux,
                          kvec_c_full_aux,
                          this->nks,
-                         this->para_k.startk_pool[GlobalV::MY_POOL],
+                         this->para_k.startk_pool[my_pool],
                          this->isk,
                          this->wk,
                          this->kvec_c,
@@ -779,7 +779,7 @@ void K_Vectors::mpi_k(std::ofstream& ofs_running)
             {
                 int isym = 0;
                 ModuleBase::Vector3<double> ks_vec(0, 0, 0);
-                if (GlobalV::MY_RANK == 0)
+                if (my_rank == 0)
                 {
                     isym = ks->first;
                     ks_vec = ks->second;
@@ -789,7 +789,7 @@ void K_Vectors::mpi_k(std::ofstream& ofs_running)
                 Parallel_Common::bcast_double(ks_vec.x);
                 Parallel_Common::bcast_double(ks_vec.y);
                 Parallel_Common::bcast_double(ks_vec.z);
-                if (GlobalV::MY_RANK != 0)
+                if (my_rank != 0)
                 {
                     this->kstars[ikibz].insert(std::make_pair(isym, ks_vec));
                 }

source/source_cell/klist.h

@@ -336,7 +336,7 @@ class K_Vectors : public ModuleCell::ReciprocalGrid
      * @note Assumes nkstot > 0 and quits if some process ends up with
      *       no k-points.
      */
-    void mpi_k(std::ofstream& ofs_running);
+    void mpi_k(std::ofstream& ofs_running, const int my_rank, const int my_pool);
 #endif
 };
 #endif // KVECT_H