Refactor: add nullptr for uninitialized pointer (#7027)

* Refactor: add nullptr for uninitialized pointer

* remove nullptr in MatrixBlock

---------

Co-authored-by: linpz <linpz@mail.ustc.edu.cn>

Author: linpeize

source/source_base/intarray.h

@@ -19,7 +19,7 @@ namespace ModuleBase
 class IntArray
 {
   public:
-    int *ptr;
+    int * ptr = nullptr;
 
     /**
      * @brief Construct a new Int Array object

source/source_base/math_chebyshev.h

@@ -249,7 +249,7 @@ class FFTW<double>
     ~FFTW();
     void execute_fftw();
     double* dcoef; //[norder2]
-    fftw_complex* ccoef;
+    fftw_complex* ccoef = nullptr;
     fftw_plan coef_plan;
 };
 
@@ -262,7 +262,7 @@ class FFTW<float>
     ~FFTW();
     void execute_fftw();
     float* dcoef; //[norder2]
-    fftwf_complex* ccoef;
+    fftwf_complex* ccoef = nullptr;
     fftwf_plan coef_plan;
 };
 #endif

source/source_base/mathzone_add1.cpp

@@ -64,7 +64,7 @@ void Mathzone_Add1::SplineD2 // modified by pengfei 13-8-8 add second derivative
 	ModuleBase::timer::tick("Mathzone_Add1","SplineD2");
 
 	double dx1, dx2, dy1, dy2, p, qn, sig, un;
-	double *u;
+	double * u = nullptr;
 
 	u = new double[mesh-1];
 	const double ypmax = 99999.00;

source/source_base/matrix_wrapper.h

@@ -21,7 +21,7 @@ class Matrix_Wrapper
 public:
 	int nr;
 	int nc;
-	double *c;
+	double * c = nullptr;
 	bool flag_delete_c;
 
 	Matrix_Wrapper(): nr(0), nc(0), c(nullptr), flag_delete_c(false){}

source/source_base/matrix_wrapper_tianhe2.h

@@ -16,7 +16,7 @@ namespace ModuleBase
 class Matrix_Wrapper
 {
 public:
-	double *c;
+	double * c = nullptr;
 	int nr;
 	int nc;
 

source/source_base/mcd.c

@@ -514,7 +514,7 @@ char *MCD_strdup(const char*s,char*fun,char*file,int line)
 char *MCD_strdup(char*s,char*fun,char*file,int line)
 #endif
 {
-	char *n;
+	char * n = nullptr;
 
 #ifdef MCD_FASTFREE
 	n=(char*)malloc(sizeof(char)*strlen(s)+1+sizeof(Chunk));
@@ -542,7 +542,7 @@ char *MCD_strndup(const char*s, int z,char*fun,char*file,int line)
 char *MCD_strndup(char*s, int z,char*fun,char*file,int line)
 #endif
 {
-	char *n;
+	char * n = nullptr;
 	int size;
 	if((signed)strlen(s)>z)
 		size=z;
@@ -575,7 +575,7 @@ int MCD_asprintf(char **ptr,const char *fmt,char *fun, char*file, int line,...)
 	int retval;
 	va_list argptr;
 #ifdef MCD_FASTFREE
-	void *fc;
+	void * fc = nullptr;
 #endif	
 
 	va_start(argptr,line);
@@ -610,7 +610,7 @@ int MCD_vasprintf(char **ptr,const char *fmt,va_list argptr,char *fun, char*file
 {
 	int retval;
 #ifdef MCD_FASTFREE
-	void *fc;
+	void * fc = nullptr;
 #endif
 
 	if((retval=vasprintf(ptr, fmt, argptr))<0)
@@ -781,7 +781,7 @@ void showMemStats()
 	Chunk*c=MemoryChunks;
 	int total=0;
 
-	FILE *o;
+	FILE * o = nullptr;
 
 	if(MemStatLog)
 		o=MemStatLog;

source/source_base/module_container/ATen/core/tensor_accessor.h

@@ -58,9 +58,9 @@ class TensorAccessorBase {
     }
 
   protected:
-    T* data_;
-    const index_t* sizes_;
-    const index_t* strides_;
+    T* data_ = nullptr;
+    const index_t* sizes_ = nullptr;
+    const index_t* strides_ = nullptr;
 };
 
 template <typename T, size_t N, typename index_t = int64_t,

source/source_base/module_container/base/core/gpu_allocator.cpp

@@ -18,7 +18,7 @@ namespace base {
 namespace core {
 // Allocate a block of memory with the given size and default alignment on GPU.
 void *GPUAllocator::allocate(size_t size) {
-    void *ptr;
+    void * ptr = nullptr;
     device_result_t result = device_malloc(&ptr, size);
     if (result != device_success) {
         return nullptr;
@@ -29,7 +29,7 @@ void *GPUAllocator::allocate(size_t size) {
 
 // Allocate a block of CPU memory with the given size and alignment.
 void *GPUAllocator::allocate(size_t size, size_t alignment) {
-    void *ptr;
+    void * ptr = nullptr;
     device_result_t result = device_malloc(&ptr, size);
     if (result != device_success) {
         return nullptr;

source/source_base/module_container/base/third_party/cusolver.h

@@ -53,7 +53,7 @@ void potri (cusolverDnHandle_t& cusolver_handle, const char& uplo, const char& d
 {
     int lwork;
     CHECK_CUSOLVER(cusolverDnSpotri_bufferSize(cusolver_handle, cublas_fill_mode(uplo), n, A, n, &lwork));
-    float* work;
+    float* work = nullptr;
     CHECK_CUDA(cudaMalloc((void**)&work, lwork * sizeof(float)));
     // Perform Cholesky decomposition
     CHECK_CUSOLVER(cusolverDnSpotri(cusolver_handle, cublas_fill_mode(uplo), n, A, n, work, lwork, nullptr));
@@ -64,7 +64,7 @@ void potri (cusolverDnHandle_t& cusolver_handle, const char& uplo, const char& d
 {
     int lwork;
     CHECK_CUSOLVER(cusolverDnDpotri_bufferSize(cusolver_handle, cublas_fill_mode(uplo), n, A, n, &lwork));
-    double* work;
+    double* work = nullptr;
     CHECK_CUDA(cudaMalloc((void**)&work, lwork * sizeof(double)));
     // Perform Cholesky decomposition
     CHECK_CUSOLVER(cusolverDnDpotri(cusolver_handle, cublas_fill_mode(uplo), n, A, n, work, lwork, nullptr));
@@ -75,7 +75,7 @@ void potri (cusolverDnHandle_t& cusolver_handle, const char& uplo, const char& d
 {
     int lwork;
     CHECK_CUSOLVER(cusolverDnCpotri_bufferSize(cusolver_handle, cublas_fill_mode(uplo), n, reinterpret_cast<cuComplex *>(A), n, &lwork));
-    cuComplex* work;
+    cuComplex* work = nullptr;
     CHECK_CUDA(cudaMalloc((void**)&work, lwork * sizeof(cuComplex)));
     // Perform Cholesky decomposition
     CHECK_CUSOLVER(cusolverDnCpotri(cusolver_handle, cublas_fill_mode(uplo), n, reinterpret_cast<cuComplex *>(A), n, work, lwork, nullptr));
@@ -86,7 +86,7 @@ void potri (cusolverDnHandle_t& cusolver_handle, const char& uplo, const char& d
 {
     int lwork;
     CHECK_CUSOLVER(cusolverDnZpotri_bufferSize(cusolver_handle, cublas_fill_mode(uplo), n, reinterpret_cast<cuDoubleComplex *>(A), n, &lwork));
-    cuDoubleComplex* work;
+    cuDoubleComplex* work = nullptr;
     CHECK_CUDA(cudaMalloc((void**)&work, lwork * sizeof(cuDoubleComplex)));
     // Perform Cholesky decomposition
     CHECK_CUSOLVER(cusolverDnZpotri(cusolver_handle, cublas_fill_mode(uplo), n, reinterpret_cast<cuDoubleComplex *>(A), n, work, lwork, nullptr));
@@ -101,7 +101,7 @@ void potrf (cusolverDnHandle_t& cusolver_handle, const char& uplo, const int& n,
     int *info = nullptr;
     CHECK_CUDA(cudaMalloc((void**)&info, 1 * sizeof(int)));
     CHECK_CUSOLVER(cusolverDnSpotrf_bufferSize(cusolver_handle, cublas_fill_mode(uplo), n, A, n, &lwork));
-    float* work;
+    float* work = nullptr;
     CHECK_CUDA(cudaMalloc((void**)&work, lwork * sizeof(float)));
     // Perform Cholesky decomposition
     CHECK_CUSOLVER(cusolverDnSpotrf(cusolver_handle, cublas_fill_mode(uplo), n, A, n, work, lwork, info));
@@ -115,7 +115,7 @@ void potrf (cusolverDnHandle_t& cusolver_handle, const char& uplo, const int& n,
     int *info = nullptr;
     CHECK_CUDA(cudaMalloc((void**)&info, 1 * sizeof(int)));
     CHECK_CUSOLVER(cusolverDnDpotrf_bufferSize(cusolver_handle, cublas_fill_mode(uplo), n, A, n, &lwork));
-    double* work;
+    double* work = nullptr;
     CHECK_CUDA(cudaMalloc((void**)&work, lwork * sizeof(double)));
     // Perform Cholesky decomposition
     CHECK_CUSOLVER(cusolverDnDpotrf(cusolver_handle, cublas_fill_mode(uplo), n, A, n, work, lwork, info));
@@ -129,7 +129,7 @@ void potrf (cusolverDnHandle_t& cusolver_handle, const char& uplo, const int& n,
     int *info = nullptr;
     CHECK_CUDA(cudaMalloc((void**)&info, 1 * sizeof(int)));
     CHECK_CUSOLVER(cusolverDnCpotrf_bufferSize(cusolver_handle, cublas_fill_mode(uplo), n, reinterpret_cast<cuComplex*>(A), lda, &lwork));
-    cuComplex* work;
+    cuComplex* work = nullptr;
     CHECK_CUDA(cudaMalloc((void**)&work, lwork * sizeof(cuComplex)));
     // Perform Cholesky decomposition
     CHECK_CUSOLVER(cusolverDnCpotrf(cusolver_handle, cublas_fill_mode(uplo), n, reinterpret_cast<cuComplex*>(A), lda, work, lwork, info));
@@ -143,7 +143,7 @@ void potrf (cusolverDnHandle_t& cusolver_handle, const char& uplo, const int& n,
     int *info = nullptr;
     CHECK_CUDA(cudaMalloc((void**)&info, 1 * sizeof(int)));
     CHECK_CUSOLVER(cusolverDnZpotrf_bufferSize(cusolver_handle, cublas_fill_mode(uplo), n, reinterpret_cast<cuDoubleComplex*>(A), lda, &lwork));
-    cuDoubleComplex* work;
+    cuDoubleComplex* work = nullptr;
     CHECK_CUDA(cudaMalloc((void**)&work, lwork * sizeof(cuDoubleComplex)));
     // Perform Cholesky decomposition
     CHECK_CUSOLVER(cusolverDnZpotrf(cusolver_handle, cublas_fill_mode(uplo), n, reinterpret_cast<cuDoubleComplex*>(A), lda, work, lwork, info));

source/source_base/module_container/base/third_party/hipsolver.h

@@ -43,7 +43,7 @@ void potri (hipsolverHandle_t& hipsolver_handle, const char& uplo, const char& d
 {
     int lwork;
     hipsolverErrcheck(hipsolverDnSpotri_bufferSize(hipsolver_handle, hipsolver_fill_mode(uplo), n, A, n, &lwork));
-    float* work;
+    float* work = nullptr;
     hipErrcheck(hipMalloc((void**)&work, lwork * sizeof(float)));
     // Perform Cholesky decomposition
     hipsolverErrcheck(hipsolverDnSpotri(hipsolver_handle, hipsolver_fill_mode(uplo), n, A, n, work, lwork, nullptr));
@@ -54,7 +54,7 @@ void potri (hipsolverHandle_t& hipsolver_handle, const char& uplo, const char& d
 {
     int lwork;
     hipsolverErrcheck(hipsolverDnDpotri_bufferSize(hipsolver_handle, hipsolver_fill_mode(uplo), n, A, n, &lwork));
-    double* work;
+    double* work = nullptr;
     hipErrcheck(hipMalloc((void**)&work, lwork * sizeof(double)));
     // Perform Cholesky decomposition
     hipsolverErrcheck(hipsolverDnDpotri(hipsolver_handle, hipsolver_fill_mode(uplo), n, A, n, work, lwork, nullptr));
@@ -65,7 +65,7 @@ void potri (hipsolverHandle_t& hipsolver_handle, const char& uplo, const char& d
 {
     int lwork;
     hipsolverErrcheck(hipsolverDnCpotri_bufferSize(hipsolver_handle, hipsolver_fill_mode(uplo), n, reinterpret_cast<hipFloatComplex *>(A), n, &lwork));
-    hipFloatComplex* work;
+    hipFloatComplex* work = nullptr;
     hipErrcheck(hipMalloc((void**)&work, lwork * sizeof(hipFloatComplex)));
     // Perform Cholesky decomposition
     hipsolverErrcheck(hipsolverDnCpotri(hipsolver_handle, hipsolver_fill_mode(uplo), n, reinterpret_cast<hipFloatComplex *>(A), n, work, lwork, nullptr));
@@ -76,7 +76,7 @@ void potri (hipsolverHandle_t& hipsolver_handle, const char& uplo, const char& d
 {
     int lwork;
     hipsolverErrcheck(hipsolverDnZpotri_bufferSize(hipsolver_handle, hipsolver_fill_mode(uplo), n, reinterpret_cast<hipDoubleComplex *>(A), n, &lwork));
-    hipDoubleComplex* work;
+    hipDoubleComplex* work = nullptr;
     hipErrcheck(hipMalloc((void**)&work, lwork * sizeof(hipDoubleComplex)));
     // Perform Cholesky decomposition
     hipsolverErrcheck(hipsolverDnZpotri(hipsolver_handle, hipsolver_fill_mode(uplo), n, reinterpret_cast<hipDoubleComplex *>(A), n, work, lwork, nullptr));
@@ -89,7 +89,7 @@ void potrf (hipsolverHandle_t& hipsolver_handle, const char& uplo, const int& n,
 {
     int lwork;
     hipsolverErrcheck(hipsolverDnSpotrf_bufferSize(hipsolver_handle, hipsolver_fill_mode(uplo), n, A, n, &lwork));
-    float* work;
+    float* work = nullptr;
     hipErrcheck(hipMalloc((void**)&work, lwork * sizeof(float)));
     // Perform Cholesky decomposition
     hipsolverErrcheck(hipsolverDnSpotrf(hipsolver_handle, hipsolver_fill_mode(uplo), n, A, n, work, lwork, nullptr));
@@ -100,7 +100,7 @@ void potrf (hipsolverHandle_t& hipsolver_handle, const char& uplo, const int& n,
 {
     int lwork;
     hipsolverErrcheck(hipsolverDnDpotrf_bufferSize(hipsolver_handle, hipsolver_fill_mode(uplo), n, A, n, &lwork));
-    double* work;
+    double* work = nullptr;
     hipErrcheck(hipMalloc((void**)&work, lwork * sizeof(double)));
     // Perform Cholesky decomposition
     hipsolverErrcheck(hipsolverDnDpotrf(hipsolver_handle, hipsolver_fill_mode(uplo), n, A, n, work, lwork, nullptr));
@@ -111,7 +111,7 @@ void potrf (hipsolverHandle_t& hipsolver_handle, const char& uplo, const int& n,
 {
     int lwork;
     hipsolverErrcheck(hipsolverDnCpotrf_bufferSize(hipsolver_handle, hipsolver_fill_mode(uplo), n, reinterpret_cast<hipFloatComplex*>(A), n, &lwork));
-    hipFloatComplex* work;
+    hipFloatComplex* work = nullptr;
     hipErrcheck(hipMalloc((void**)&work, lwork * sizeof(hipFloatComplex)));
     // Perform Cholesky decomposition
     hipsolverErrcheck(hipsolverDnCpotrf(hipsolver_handle, hipsolver_fill_mode(uplo), n, reinterpret_cast<hipFloatComplex*>(A), n, work, lwork, nullptr));
@@ -122,7 +122,7 @@ void potrf (hipsolverHandle_t& hipsolver_handle, const char& uplo, const int& n,
 {
     int lwork;
     hipsolverErrcheck(hipsolverDnZpotrf_bufferSize(hipsolver_handle, hipsolver_fill_mode(uplo), n, reinterpret_cast<hipDoubleComplex*>(A), n, &lwork));
-    hipDoubleComplex* work;
+    hipDoubleComplex* work = nullptr;
     hipErrcheck(hipMalloc((void**)&work, lwork * sizeof(hipDoubleComplex)));
     // Perform Cholesky decomposition
     hipsolverErrcheck(hipsolverDnZpotrf(hipsolver_handle, hipsolver_fill_mode(uplo), n, reinterpret_cast<hipDoubleComplex*>(A), n, work, lwork, nullptr));