Refactor: remove source_lcao dependency from source_hsolver (#7683)

HSolverLCAO::solve computed the charge density directly via the
source_lcao free function LCAO_domain::dm2rho, making source_hsolver
depend on source_lcao.

Delegate the charge-density calculation through a new thin
ElecStateLCAO::dmToRho wrapper (source_estate, which already depends on
source_lcao). This mirrors the existing pexsi branch (_pes->dm2rho) and
the plane-wave path (ElecStatePW::psiToRho), and removes the only direct
source_lcao include from source_hsolver.

No functional change.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: Critsium-xy

source/source_estate/elecstate_lcao.cpp

@@ -7,6 +7,7 @@
 #include "source_io/module_parameter/parameter.h"
 
 #include "source_lcao/module_gint/gint_interface.h"
+#include "source_lcao/rho_tau_lcao.h"
 
 #include <vector>
 
@@ -84,6 +85,15 @@ void ElecStateLCAO<std::complex<double>>::dm2rho(std::vector<std::complex<double
 }
 
 
+template <typename TK>
+void ElecStateLCAO<TK>::dmToRho(std::vector<hamilt::HContainer<double>*>& dmr,
+                                int nspin,
+                                Charge* chr,
+                                bool skip_charge)
+{
+    LCAO_domain::dm2rho(dmr, nspin, chr, skip_charge);
+}
+
 template class ElecStateLCAO<double>;               // Gamma_only case
 template class ElecStateLCAO<std::complex<double>>; // multi-k case
 

source/source_estate/elecstate_lcao.h

@@ -39,10 +39,23 @@ class ElecStateLCAO : public ElecState
      * @param pexsi_EDM: pointers of energy-weighed density matrix (EDMK) calculated by pexsi, needed by MD, will be
      * stored in DensityMatrix::pexsi_EDM
      */
-	void dm2rho(std::vector<TK*> pexsi_DM, 
-			std::vector<TK*> pexsi_EDM, 
+	void dm2rho(std::vector<TK*> pexsi_DM,
+			std::vector<TK*> pexsi_EDM,
 			DensityMatrix<TK, double>* dm);
 
+    /**
+     * @brief calculate electronic charge density from the density matrix (DMR)
+     *
+     * Thin wrapper over LCAO_domain::dm2rho so that HSolverLCAO delegates the
+     * charge-density calculation through the ElecState interface, mirroring the
+     * plane-wave path (ElecStatePW::psiToRho) and the pexsi branch above. This
+     * keeps the source_lcao dependency out of source_hsolver.
+     */
+    void dmToRho(std::vector<hamilt::HContainer<double>*>& dmr,
+                 int nspin,
+                 Charge* chr,
+                 bool skip_charge = false);
+
 };
 
 template <typename TK>

source/source_hsolver/hsolver_lcao.cpp

@@ -35,8 +35,6 @@
 #include "source_hsolver/parallel_k2d.h"
 #include "source_io/module_parameter/parameter.h"
 
-#include "source_lcao/rho_tau_lcao.h" // mohan add 20251024
-
 namespace hsolver
 {
 
@@ -103,7 +101,9 @@ void HSolverLCAO<TK, Device>::solve(hamilt::Hamilt<TK>* pHamilt,
         if (!skip_charge)
         {
             // compute charge density from density matrix, mohan update 20251024
-            LCAO_domain::dm2rho(dm.get_DMR_vector(), nspin, &chr);
+            // delegate to ElecStateLCAO to keep the source_lcao dependency out of
+            // source_hsolver (mirrors the pexsi branch below and the PW psiToRho path)
+            dynamic_cast<elecstate::ElecStateLCAO<TK>*>(pes)->dmToRho(dm.get_DMR_vector(), nspin, &chr);
         }
         else
         {