Skip to content

Commit 8c12155

Browse files
committed
docs: strengthen governance PR follow-up
1 parent 6ee2e9b commit 8c12155

3 files changed

Lines changed: 29 additions & 0 deletions

File tree

AGENTS.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,19 @@ rules. Read the complete governance document before making or reviewing changes:
5858
compiler setup, or calculation-task skill unless the PR explicitly requires
5959
and justifies it.
6060

61+
## Local Runtime Testing
62+
63+
- Set `OMP_NUM_THREADS=1` for ABACUS runtime, integration, and MPI tests unless
64+
a test explicitly requires another value.
65+
- Run MPI/runtime tests outside restricted sandboxes when process visibility,
66+
sockets, or MPI launch behavior matters.
67+
- Treat OpenMPI `opal_ifinit: socket() failed errno=1` warnings from sandboxed
68+
MPI-linked builds or runs as expected sandbox artifacts; rerun outside the
69+
sandbox before treating them as ABACUS failures.
70+
- Do not relax existing tests or references merely to make a failure pass.
71+
Update references only when the intended behavior changed and the PR explains
72+
why.
73+
6174
## Review And Exception Flow
6275

6376
- Mechanical blockers are enforced by hook and CI only for new files, changed

docs/developers_guide/agent_governance.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,20 @@ Do not add a new container recipe, toolchain path, or agent-specific skill for
141141
calculation tasks as part of governance-only work. If a future PR needs one, it
142142
must explain why the existing Docker/toolchain paths are insufficient.
143143

144+
## Local Runtime And MPI Testing
145+
146+
Use `OMP_NUM_THREADS=1` as the default for ABACUS runtime, integration, and MPI
147+
tests unless the test explicitly requires another thread count. Agent sandboxes
148+
can interfere with process visibility, socket creation, and MPI launch behavior;
149+
when those details affect a result, rerun the command outside the restricted
150+
sandbox before diagnosing an ABACUS failure.
151+
152+
OpenMPI `opal_ifinit: socket() failed errno=1` warnings from sandboxed
153+
MPI-linked builds or runs should be treated as sandbox artifacts first, not as
154+
project regressions. Do not relax existing integration tests or reference files
155+
just to make a failure pass. Update references only when the intended behavior
156+
changed and the PR explains why the new reference is correct.
157+
144158
## CLI Verification
145159

146160
When a usable ABACUS executable is present, INPUT and command-line changes

source/Makefile.Objects

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -415,6 +415,8 @@ OBJS_NEIGHBOR=sltk_atom.o\
415415

416416
OBJS_NEIGHBOR_SEARCH=neighbor_search.o\
417417
bin_manager.o\
418+
page_allocator.o\
419+
unitcell_lite.o\
418420

419421

420422
OBJS_ORBITAL=ORB_atomic.o\

0 commit comments

Comments
 (0)