Skip to content

Commit ec6081b

Browse files
authored
fix bug:correct handle when meets PermissionError (#460)
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved log file path creation logic to enhance reliability. - Added detailed log messages for file initialization. - Enhanced error handling for permission issues when creating log files. - Adjusted log handlers for better log management. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 parents 661882a + 3725aee commit ec6081b

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

dpdispatcher/dlog.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,25 @@
66
dlog = logging.getLogger("dpdispatcher")
77
dlog.propagate = False
88
dlog.setLevel(logging.INFO)
9+
cwd_logfile_path = os.path.join(os.getcwd(), "dpdispatcher.log")
10+
dlogf = logging.FileHandler(cwd_logfile_path, delay=True)
911
try:
10-
dlogf = logging.FileHandler(
11-
os.getcwd() + os.sep + "dpdispatcher" + ".log", delay=True
12-
)
12+
dlog.addHandler(dlogf)
13+
dlog.info(f"LOG INIT:dpdispatcher log direct to {cwd_logfile_path}")
1314
except PermissionError:
15+
dlog.removeHandler(dlogf)
1416
warnings.warn(
15-
"dpdispatcher.log meet permission error. redirect the log to ~/dpdispatcher.log"
17+
f"dump logfile dpdispatcher.log to {cwd_logfile_path} meet permission error. redirect the log to ~/dpdispatcher.log"
1618
)
1719
dlogf = logging.FileHandler(
1820
os.path.join(os.path.expanduser("~"), "dpdispatcher.log"), delay=True
1921
)
22+
dlog.addHandler(dlogf)
23+
dlog.info("LOG INIT:dpdispatcher log init at ~/dpdispatcher.log")
2024

2125
dlogf_formatter = logging.Formatter("%(asctime)s - %(levelname)s : %(message)s")
2226
dlogf.setFormatter(dlogf_formatter)
23-
dlog.addHandler(dlogf)
27+
# dlog.addHandler(dlogf)
2428

2529
dlog_stdout = logging.StreamHandler(sys.stdout)
2630
dlog_stdout.setFormatter(dlogf_formatter)

0 commit comments

Comments
 (0)