Clean up unused imports and improve type hints (#324)

This pull request primarily removes unused imports and cleans up type
annotations across several modules in the `dpgen2` codebase. These
changes help streamline the code, reduce unnecessary dependencies, and
improve readability. Additionally, some minor logic and formatting
updates are included to modernize the code and ensure consistency.

### Code cleanup and import removal

* Removed unused imports such as `os`, `json`, `logging`, `glob`,
`pickle`, and several type hints (`Set`, `Union`, etc.) from multiple
files including `main.py`, `showkey.py`, `status.py`, `submit.py`,
`watch.py`, `workflow.py`, `prep_fp.py`, `run_fp.py`, and `vasp.py`.
This reduces clutter and potential confusion for future maintenance.
[[1]](diffhunk://#diff-566f49ecd2afbc4c7a22cd2f576a706a0fea95bed20f560240e328541830494dL4-L19)
[[2]](diffhunk://#diff-dc5e3ffd275993a4866b65927e0972ad7c65aac2e195b3ca9fdb43254278f265L1-L8)
[[3]](diffhunk://#diff-70638d2beeba19acd9b8de0bdf0bf976ba14b6f5e5f8dd24b1f84aaf23840425L4-L6)
[[4]](diffhunk://#diff-518b16955e40ff2d3d6308e0dff9a6800306adecead3255ccf8c71a146723588L2-L7)
[[5]](diffhunk://#diff-518b16955e40ff2d3d6308e0dff9a6800306adecead3255ccf8c71a146723588L18-L23)
[[6]](diffhunk://#diff-b80b08ddd1a5fe0cc9352de549f54b44ca1fbd63fd6e1300c756818bf2ef2dfdL7)
[[7]](diffhunk://#diff-74c1d2a47b53b85b573096163113600a7dd410f2a410bc9699e90c26af23d226L2-L4)
[[8]](diffhunk://#diff-8d2a04f59606da4f76ec76bc363f743a27ee018f3be91607b428165a5b56cba8L1-L2)
[[9]](diffhunk://#diff-8d2a04f59606da4f76ec76bc363f743a27ee018f3be91607b428165a5b56cba8L12-L16)
[[10]](diffhunk://#diff-c7fc0e85df33ae92aa2222a509449350292360031e74b03b169a3c7ba84dec29L1)
[[11]](diffhunk://#diff-c7fc0e85df33ae92aa2222a509449350292360031e74b03b169a3c7ba84dec29L13-L18)
[[12]](diffhunk://#diff-2f01a3587ee0b6fde430a0c71d0542ec7bd74bf9e57da500338b11afbf0df1c1L9-L14)
[[13]](diffhunk://#diff-34aa3497602bd93c83e17bd39502560ca7c9b6d09bacba3af33be0244a784477L13)

### Type annotation improvements

* Updated function signatures to use modern type hinting, such as
changing `Optional[Dict] = {}` to `Optional[Dict] | None = None` and
ensuring default values are properly handled with `wf_config = wf_config
or {}`. This makes the code safer and more in line with current Python
standards.
[[1]](diffhunk://#diff-b80b08ddd1a5fe0cc9352de549f54b44ca1fbd63fd6e1300c756818bf2ef2dfdL46-R67)
[[2]](diffhunk://#diff-74c1d2a47b53b85b573096163113600a7dd410f2a410bc9699e90c26af23d226L41-R40)

### Minor logic and formatting updates

* Improved string formatting in logging statements and conditional
checks for better readability and consistency. For example, switched to
f-strings with consistent quotation marks and improved assertion error
messages.
[[1]](diffhunk://#diff-b80b08ddd1a5fe0cc9352de549f54b44ca1fbd63fd6e1300c756818bf2ef2dfdL46-R67)
[[2]](diffhunk://#diff-518b16955e40ff2d3d6308e0dff9a6800306adecead3255ccf8c71a146723588L591-R584)

These changes collectively enhance code maintainability and readability
without altering core functionality.This pull request primarily cleans
up unused imports and improves code readability across several
entrypoint modules in the `dpgen2` package. It also introduces minor
enhancements to type hints and default argument handling for better code
clarity and robustness.

**Codebase cleanup and readability:**

* Removed unused imports (such as `os`, `glob`, `pickle`, `dpdata`,
etc.) from multiple files including `main.py`, `showkey.py`,
`status.py`, `submit.py`, and `workflow.py` to streamline the codebase.
[[1]](diffhunk://#diff-566f49ecd2afbc4c7a22cd2f576a706a0fea95bed20f560240e328541830494dL4-L19)
[[2]](diffhunk://#diff-dc5e3ffd275993a4866b65927e0972ad7c65aac2e195b3ca9fdb43254278f265L1-L8)
[[3]](diffhunk://#diff-70638d2beeba19acd9b8de0bdf0bf976ba14b6f5e5f8dd24b1f84aaf23840425L4-L6)
[[4]](diffhunk://#diff-518b16955e40ff2d3d6308e0dff9a6800306adecead3255ccf8c71a146723588L2-L7)
[[5]](diffhunk://#diff-74c1d2a47b53b85b573096163113600a7dd410f2a410bc9699e90c26af23d226L2-R2)
* Simplified assertion error messages and improved string formatting for
logging statements in `submit.py` and `watch.py`.
[[1]](diffhunk://#diff-518b16955e40ff2d3d6308e0dff9a6800306adecead3255ccf8c71a146723588L591-R583)
[[2]](diffhunk://#diff-b80b08ddd1a5fe0cc9352de549f54b44ca1fbd63fd6e1300c756818bf2ef2dfdL46-R67)

**Type hint and argument improvements:**

* Updated type hints for optional dictionary arguments in `watch.py` and
`workflow.py` to use `Optional[Dict] | None`, and ensured proper default
initialization using `wf_config = wf_config or {}`.
[[1]](diffhunk://#diff-b80b08ddd1a5fe0cc9352de549f54b44ca1fbd63fd6e1300c756818bf2ef2dfdL46-R67)
[[2]](diffhunk://#diff-74c1d2a47b53b85b573096163113600a7dd410f2a410bc9699e90c26af23d226L41-R38)
* Minor formatting improvements for argument parsing and function calls
for better readability in `main.py`.
[[1]](diffhunk://#diff-566f49ecd2afbc4c7a22cd2f576a706a0fea95bed20f560240e328541830494dL87-R77)
[[2]](diffhunk://#diff-566f49ecd2afbc4c7a22cd2f576a706a0fea95bed20f560240e328541830494dL384-R372)

**General code style enhancements:**

* Removed unnecessary tuple and union type imports, and cleaned up type
hints in `submit.py` and `status.py`.
[[1]](diffhunk://#diff-518b16955e40ff2d3d6308e0dff9a6800306adecead3255ccf8c71a146723588L18-L23)
[[2]](diffhunk://#diff-70638d2beeba19acd9b8de0bdf0bf976ba14b6f5e5f8dd24b1f84aaf23840425L4-L6)
[[3]](diffhunk://#diff-b80b08ddd1a5fe0cc9352de549f54b44ca1fbd63fd6e1300c756818bf2ef2dfdL7)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Refactor**
* Removed numerous unused imports across entry points and FP modules to
reduce dependency surface and trim code.
  * Standardized logging/string formatting for consistency.

* **Bug Fixes**
* Changed workflow-config default from a mutable empty dict to None with
internal initialization to avoid shared-state issues.
* Corrected membership check used when computing finished-step diffs to
fix status reporting.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: thangckt

dpgen2/entrypoint/main.py

@@ -1,22 +1,12 @@
 import argparse
 import json
 import logging
-import os
 import textwrap
 from typing import (
     List,
     Optional,
 )
 
-import dflow
-from dflow import (
-    Step,
-    Steps,
-    Workflow,
-    download_artifact,
-    upload_artifact,
-)
-
 from dpgen2 import (
     __version__,
 )

dpgen2/entrypoint/showkey.py

@@ -1,11 +1,3 @@
-import glob
-import os
-import pickle
-from pathlib import (
-    Path,
-)
-
-import dpdata
 from dflow import (
     Workflow,
 )

dpgen2/entrypoint/status.py

@@ -1,9 +1,7 @@
 import logging
 from typing import (
     Dict,
-    List,
     Optional,
-    Union,
 )
 
 from dflow import (

dpgen2/entrypoint/submit.py

@@ -1,10 +1,7 @@
 import copy
-import glob
 import json
 import logging
 import os
-import pickle
-import re
 from copy import (
     deepcopy,
 )
@@ -15,12 +12,8 @@
     Dict,
     List,
     Optional,
-    Tuple,
-    Type,
-    Union,
 )
 
-import dpdata
 from dflow import (
     ArgoStep,
     InputArtifact,
@@ -588,7 +581,7 @@ def workflow_concurrent_learning(
     if fp_style == "deepmd":
         assert (
             "teacher_model_path" in fp_config["run"]
-        ), f"Cannot find 'teacher_model_path' in config['fp']['run_config'] when fp_style == 'deepmd'"
+        ), "Cannot find 'teacher_model_path' in config['fp']['run_config'] when fp_style == 'deepmd'"
         assert os.path.exists(
             fp_config["run"]["teacher_model_path"]
         ), f"No such file: {fp_config['run']['teacher_model_path']}"

dpgen2/entrypoint/watch.py

@@ -4,7 +4,6 @@
     Dict,
     List,
     Optional,
-    Union,
 )
 
 from dflow import (
@@ -43,28 +42,29 @@ def update_finished_steps(
     if finished_keys is not None:
         diff_keys = []
         for kk in wf_keys:
-            if not (kk in finished_keys):
+            if kk not in finished_keys:
                 diff_keys.append(kk)
     else:
         diff_keys = wf_keys
     for kk in diff_keys:
-        logging.info(f'steps {kk.ljust(50,"-")} finished')
+        logging.info(f"steps {kk.ljust(50, '-')} finished")
         if download:
             download_dpgen2_artifacts(wf, kk, prefix=prefix, chk_pnt=chk_pnt)
-            logging.info(f'steps {kk.ljust(50,"-")} downloaded')
+            logging.info(f"steps {kk.ljust(50, '-')} downloaded")
     finished_keys = wf_keys
     return finished_keys
 
 
 def watch(
     workflow_id,
-    wf_config: Optional[Dict] = {},
+    wf_config: Optional[dict] = None,
     watching_keys: Optional[List] = default_watching_keys,
     frequency: float = 600.0,
     download: bool = False,
     prefix: Optional[str] = None,
     chk_pnt: bool = False,
 ):
+    wf_config = wf_config or {}
     wf_config = normalize_args(wf_config)
 
     global_config_workflow(wf_config)

dpgen2/entrypoint/workflow.py

@@ -1,7 +1,4 @@
 import argparse
-import json
-import logging
-import os
 from typing import (
     Optional,
 )
@@ -38,8 +35,9 @@ def add_subparser_workflow_subcommand(subparsers, command: str):
 def execute_workflow_subcommand(
     command: str,
     wfid: str,
-    wf_config: Optional[dict] = {},
+    wf_config: Optional[dict] = None,
 ):
+    wf_config = wf_config or {}
     wf_config = normalize_args(wf_config)
     global_config_workflow(wf_config)
     wf = Workflow(id=wfid)

dpgen2/fp/prep_fp.py

@@ -1,5 +1,3 @@
-import json
-import os
 from abc import (
     ABC,
     abstractmethod,
@@ -9,11 +7,8 @@
 )
 from typing import (
     Any,
-    Dict,
     List,
-    Set,
     Tuple,
-    Union,
 )
 
 import dpdata

dpgen2/fp/run_fp.py

@@ -1,4 +1,3 @@
-import json
 import os
 from abc import (
     ABC,
@@ -10,12 +9,10 @@
 from typing import (
     Dict,
     List,
-    Set,
     Tuple,
 )
 
 import dargs
-import dpdata
 from dflow.python import (
     OP,
     OPIO,

dpgen2/fp/vasp.py

@@ -6,12 +6,8 @@
     Path,
 )
 from typing import (
-    Dict,
     List,
-    Optional,
-    Set,
     Tuple,
-    Union,
 )
 
 import dpdata

dpgen2/fp/vasp_input.py

@@ -10,7 +10,6 @@
     Union,
 )
 
-import dpdata
 import numpy as np
 from dargs import (
     Argument,