test: update test_update_pipeline_yaml_success_json_response to use MockHttpClient

Author: mathislucka

test/test_main.py

@@ -50,19 +50,43 @@ def create_mock_response(
 # --- Test Cases ---
 
 
+@pytest.mark.asyncio
 @mock.patch.dict(os.environ, {"DEEPSET_WORKSPACE": TEST_WORKSPACE, "DEEPSET_API_KEY": TEST_API_KEY})
-@mock.patch("deepset_mcp.client.DeepsetClient.update_pipeline_yaml")
-def test_update_pipeline_yaml_success_json_response(mock_update: mock.Mock) -> None:
+async def test_update_pipeline_yaml_success_json_response() -> None:
     """Tests successful update with JSON response."""
-    mock_update.return_value = {"status": "success", "message": "Updated"}
-
-    # Since update_pipeline_yaml is now an async function wrapped with async_to_sync,
-    # we need to mock the async method but test the sync wrapper
-    result = update_pipeline_yaml(TEST_PIPELINE_NAME, VALID_YAML_CONTENT)
-
-    # Check that the DeepsetClient's update_pipeline_yaml method was called with the right args
-    mock_update.assert_called_once_with(TEST_PIPELINE_NAME, VALID_YAML_CONTENT)
-    assert result == {"status": "success", "message": "Updated"}
+    # Create a mock client with the expected responses
+    mock_responses = {}
+    update_response = mock.Mock(spec=httpx.Response)
+    update_response.status_code = 200
+    update_response.text = '{"status": "success", "message": "Updated"}'
+    update_response.json.return_value = {"status": "success", "message": "Updated"}
+    
+    endpoint = f"/workspaces/{TEST_WORKSPACE}/pipelines/{TEST_PIPELINE_NAME}/yaml"
+    url = f"{DEEPSET_API_BASE_URL}{endpoint}"
+    mock_responses[f"PUT {url}"] = update_response
+    
+    mock_client = MockHttpClient(mock_responses)
+    
+    # Since update_pipeline_yaml is async, we need to test it differently
+    with mock.patch("deepset_mcp.main.DeepsetClient") as mock_client_class:
+        # Setup the mock client instance
+        mock_client_instance = mock.MagicMock()
+        mock_client_instance.__aenter__.return_value = mock_client_instance
+        mock_client_instance.__aexit__.return_value = None
+        mock_client_instance.workspace = TEST_WORKSPACE
+        mock_client_instance.request.return_value = {"status": "success", "message": "Updated"}
+        mock_client_class.return_value = mock_client_instance
+        
+        # Call the function
+        result = await update_pipeline_yaml(TEST_PIPELINE_NAME, VALID_YAML_CONTENT)
+        
+        # Verify the call was made correctly
+        mock_client_instance.request.assert_called_once_with(
+            f"/workspaces/{TEST_WORKSPACE}/pipelines/{TEST_PIPELINE_NAME}/yaml", 
+            method="PUT", 
+            data={"query_yaml": VALID_YAML_CONTENT}
+        )
+        assert result == {"status": "success", "message": "Updated"}
 
 
 @mock.patch.dict(os.environ, {"DEEPSET_WORKSPACE": TEST_WORKSPACE, "DEEPSET_API_KEY": TEST_API_KEY})