pin hub > 0.35.0

Author: anakin87

integrations/huggingface_api/pyproject.toml

@@ -23,7 +23,7 @@ classifiers = [
   "Programming Language :: Python :: Implementation :: CPython",
   "Programming Language :: Python :: Implementation :: PyPy",
 ]
-dependencies = ["haystack-ai>=2.30.0", "huggingface_hub[inference]>=0.27.0"]
+dependencies = ["haystack-ai>=2.30.0", "huggingface_hub[inference]>=0.35.0"]
 
 [project.urls]
 Documentation = "https://github.com/deepset-ai/haystack-core-integrations/tree/main/integrations/huggingface_api#readme"

integrations/huggingface_api/src/haystack_integrations/components/generators/huggingface_api/chat/chat_generator.py

@@ -148,20 +148,15 @@ def _convert_tools_to_hfapi_tools(tools: ToolsType | None) -> list["ChatCompleti
     if not tools:
         return None
 
-    # huggingface_hub<0.31.0 uses "arguments", huggingface_hub>=0.31.0 uses "parameters"
-    parameters_name = "arguments" if hasattr(ChatCompletionInputFunctionDefinition, "arguments") else "parameters"
-
     hf_tools = []
     for tool in flatten_tools_or_toolsets(tools):
-        hf_tools_args = {
-            "name": tool.name,
-            "description": tool.description,
-            parameters_name: _resolve_schema_refs(tool.parameters),
-        }
-
         hf_tools.append(
             ChatCompletionInputTool(
-                function=ChatCompletionInputFunctionDefinition(**hf_tools_args),  # type: ignore[arg-type]
+                function=ChatCompletionInputFunctionDefinition(
+                    name=tool.name,
+                    description=tool.description,
+                    parameters=_resolve_schema_refs(tool.parameters),
+                ),
                 type="function",
             )
         )

integrations/huggingface_api/tests/test_chat_generator.py

@@ -1231,28 +1231,6 @@ def test_convert_tools_to_hfapi_tools(self):
         assert hf_tools[0].function.description == "useful to determine the weather in a given location"
         assert hf_tools[0].function.parameters == {"city": {"type": "string"}}
 
-    def test_convert_tools_to_hfapi_tools_legacy(self):
-        # this satisfies the check hasattr(ChatCompletionInputFunctionDefinition, "arguments")
-        mock_class = MagicMock()
-
-        with patch(
-            "haystack_integrations.components.generators.huggingface_api.chat.chat_generator.ChatCompletionInputFunctionDefinition",
-            mock_class,
-        ):
-            tool = Tool(
-                name="weather",
-                description="useful to determine the weather in a given location",
-                parameters={"city": {"type": "string"}},
-                function=get_weather,
-            )
-            _convert_tools_to_hfapi_tools([tool])
-
-        mock_class.assert_called_once_with(
-            name="weather",
-            arguments={"city": {"type": "string"}},
-            description="useful to determine the weather in a given location",
-        )
-
     def test_warm_up_with_tools(self, mock_check_valid_model):
         """Test that warm_up() calls warm_up on tools and is idempotent."""