Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make system_prompt in Generators a runtime parameter as well #8394

Open
sjrl opened this issue Sep 24, 2024 · 1 comment
Open

feat: Make system_prompt in Generators a runtime parameter as well #8394

sjrl opened this issue Sep 24, 2024 · 1 comment
Assignees

Comments

@sjrl
Copy link
Contributor

sjrl commented Sep 24, 2024

It'd be nice to be able to change the system prompt at run time to allow for easier experimentation when working with pipelines defined in yaml files. Otherwise it requires changing the yaml file to test changes rather than being able to change the call to the pipeline run method to insert a new system prompt at run time.

I don't think this would be a breaking change since it would just add a new optional parameter to the run method of our generators.

@davidsbatista
Copy link
Contributor

Hi @sjrl - here's a draft PR: https://github.com/deepset-ai/haystack/pull/8423/files

Let me know if this is what you are after. We then need to add it to every possible generator, to make it coherent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants