Skip to content

Commit 35eabb0

Browse files
authored
Fix issues w. python 3.6 + add py-version checks to CI (#2589)
1 parent 18713c6 commit 35eabb0

File tree

7 files changed

+51
-13
lines changed

7 files changed

+51
-13
lines changed

.github/workflows/python.yml

+39
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
name: python
2+
3+
on:
4+
push:
5+
branches:
6+
- 'master'
7+
- 'staging**'
8+
pull_request:
9+
branches:
10+
'**'
11+
12+
concurrency:
13+
group: ${{ github.workflow }}-${{ github.ref }}
14+
cancel-in-progress: true
15+
16+
jobs:
17+
version-check:
18+
strategy:
19+
matrix:
20+
pyVersion: ["3.6", "3.7", "3.8", "3.9", "3.10"]
21+
fail-fast: false
22+
23+
runs-on: ubuntu-20.04
24+
container:
25+
image: deepspeed/gh-builder:py${{ matrix.pyVersion }}
26+
27+
steps:
28+
- uses: actions/checkout@v2
29+
30+
- name: environment
31+
run: |
32+
which python
33+
python --version
34+
- name: Install deepspeed
35+
run: |
36+
pip3 install .
37+
- name: DS Report
38+
run: |
39+
ds_report

deepspeed/model_implementations/diffusers/unet.py

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ def __init__(self, unet, enable_cuda_graph=True):
1212
self.in_channels = unet.in_channels
1313
self.device = self.unet.device
1414
self.dtype = self.unet.dtype
15+
self.config = self.unet.config
1516
self.fwd_count = 0
1617
self.unet.requires_grad_(requires_grad=False)
1718
self.unet.to(memory_format=torch.channels_last)

deepspeed/module_inject/replace_module.py

+7-4
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,12 @@
33
import tqdm
44
import deepspeed
55
import deepspeed.ops.transformer as transformer_inference
6+
from deepspeed.ops.transformer.inference.diffusers_attention import DeepSpeedDiffusersAttention
7+
from deepspeed.ops.transformer.inference.diffusers_transformer_block import DeepSpeedDiffusersTransformerBlock
8+
from deepspeed.ops.transformer.inference.diffusers_2d_transformer import Diffusers2DTransformerConfig
69
from .replace_policy import HFBertLayerPolicy, HFGPT2LayerPolicy, BLOOMLayerPolicy
710
from .replace_policy import replace_policies, generic_policies
8-
#from ..runtime.weight_quantizer import WeightQuantization
11+
912
from deepspeed import comm as dist
1013
from torch import nn
1114

@@ -211,7 +214,7 @@ def replace_attn(child, policy):
211214
triangular_masking=False,
212215
max_out_tokens=4096,
213216
)
214-
attn_module = transformer_inference.DeepSpeedDiffusersAttention(config)
217+
attn_module = DeepSpeedDiffusersAttention(config)
215218

216219
def transpose(data):
217220
data = data.contiguous()
@@ -234,8 +237,8 @@ def transpose(data):
234237
return attn_module
235238

236239
def replace_attn_block(child, policy):
237-
config = transformer_inference.Diffusers2DTransformerConfig()
238-
return transformer_inference.DeepSpeedDiffusersTransformerBlock(child, config)
240+
config = Diffusers2DTransformerConfig()
241+
return DeepSpeedDiffusersTransformerBlock(child, config)
239242

240243
if isinstance(module, torch.nn.Module):
241244
pass

deepspeed/ops/transformer/__init__.py

-3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,3 @@
22
from .inference.config import DeepSpeedInferenceConfig
33
from ...model_implementations.transformers.ds_transformer import DeepSpeedTransformerInference
44
from .inference.moe_inference import DeepSpeedMoEInferenceConfig, DeepSpeedMoEInference
5-
from .inference.diffusers_attention import DeepSpeedDiffusersAttention
6-
from .inference.diffusers_transformer_block import DeepSpeedDiffusersTransformerBlock
7-
from .inference.diffusers_2d_transformer import Diffusers2DTransformerConfig
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
11
from .config import DeepSpeedInferenceConfig
22
from ....model_implementations.transformers.ds_transformer import DeepSpeedTransformerInference
33
from .moe_inference import DeepSpeedMoEInferenceConfig, DeepSpeedMoEInference
4-
from .diffusers_attention import DeepSpeedDiffusersAttention
5-
from .diffusers_transformer_block import DeepSpeedDiffusersTransformerBlock
6-
from .diffusers_2d_transformer import Diffusers2DTransformerConfig

deepspeed/ops/transformer/inference/diffusers_transformer_block.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
import torch
66
import torch.nn as nn
77
from ... import op_builder
8-
from ....module_inject import GroupQuantizer
98

9+
from deepspeed import module_inject
1010
from .diffusers_attention import DeepSpeedDiffusersAttention
1111
from .bias_add import nhwc_bias_add
1212
from .diffusers_2d_transformer import Diffusers2DTransformerConfig
@@ -35,7 +35,7 @@ def __init__(self,
3535
equivalent_module: nn.Module,
3636
config: Diffusers2DTransformerConfig):
3737
super(DeepSpeedDiffusersTransformerBlock, self).__init__()
38-
self.quantizer = GroupQuantizer(q_int8=config.int8_quantization)
38+
self.quantizer = module_inject.GroupQuantizer(q_int8=config.int8_quantization)
3939
# Ensure ops are built by the time we start running
4040
self.config = config
4141

setup.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,8 @@ def create_dir_symlink(src, dest):
305305
'Programming Language :: Python :: 3.6',
306306
'Programming Language :: Python :: 3.7',
307307
'Programming Language :: Python :: 3.8',
308-
'Programming Language :: Python :: 3.9'
308+
'Programming Language :: Python :: 3.9',
309+
'Programming Language :: Python :: 3.10'
309310
],
310311
license='MIT',
311312
ext_modules=ext_modules,

0 commit comments

Comments
 (0)