Skip to content

Commit af53757

Browse files
authored
chore: remove open module references and stop publishing serve-exampmle (#5)
1 parent 96183a6 commit af53757

5 files changed

Lines changed: 10 additions & 21 deletions

File tree

CLAUDE.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ For detailed architecture, see [docs/CODEBASE_MAP.md](docs/CODEBASE_MAP.md).
2020
- **Test method names** must start with `should` or `shouldNot`
2121
- **No mocks**: use stub implementations (`StubRequest`, `StubResponse`) in tests
2222
- **Middleware order**: first-registered = outermost (applied in reverse)
23-
- All modules are `open module` with explicit `requires`/`exports`
2423

2524
## Build
2625

docs/CODEBASE_MAP.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ serve.build/
154154
- `{param}` route patterns compiled to regex at `Route` construction time; prefix routes append `(/.*)?$`
155155
- Attribute bag on `Exchange` with typed `attribute(key, Class<T>)` access
156156

157-
**Exports:** `build.serve.foundation` (split into sub-packages; all open module)
157+
**Exports:** `build.serve.foundation` (split into sub-packages)
158158

159159
**Dependencies:** `build.base.configuration`, `build.base.telemetry`, `java.logging`
160160

@@ -701,7 +701,7 @@ sequenceDiagram
701701
- **Null policy:** `Optional<T>` in public APIs; internal code avoids null by convention
702702
- **Test naming:** methods must start with `should` or `shouldNot`
703703
- **Test implementation:** no mocks; stub/test implementations (`TestRequest`, `TestResponse`, `TestServer`)
704-
- **Module structure:** all modules are `open module` with explicit `requires`/`exports`
704+
- **Module structure:** all modules have explicit `requires`/`exports`
705705
- **Middleware:** `first-registered = outermost` (applied in reverse within `RouterBuilder`)
706706
- **Factories over constructors:** static factory methods (`of`, `builder`, `defaults`) used consistently
707707
- **Records for options and value types:** `ListenAddress`, `MaxRequestSize`, `SseEvent`, `Task`, etc.

pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -367,6 +367,7 @@
367367
<configuration>
368368
<publishingServerId>central</publishingServerId>
369369
<autoPublish>true</autoPublish>
370+
<excludeArtifacts>serve-example</excludeArtifacts>
370371
</configuration>
371372
</plugin>
372373
</plugins>

serve-example/pom.xml

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -185,22 +185,5 @@
185185
</plugins>
186186
</build>
187187

188-
<profiles>
189-
<profile>
190-
<id>deploy</id>
191-
<build>
192-
<plugins>
193-
<plugin>
194-
<groupId>org.sonatype.central</groupId>
195-
<artifactId>central-publishing-maven-plugin</artifactId>
196-
<version>${maven-central-publishing-plugin.version}</version>
197-
<configuration>
198-
<skipPublishing>true</skipPublishing>
199-
</configuration>
200-
</plugin>
201-
</plugins>
202-
</build>
203-
</profile>
204-
</profiles>
205188

206189
</project>

serve-example/src/main/java/module-info.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
* @author reed.vonredwitz
2424
* @since Mar-2026
2525
*/
26-
open module build.serve.example {
26+
module build.serve.example {
2727
requires build.serve.application;
2828
requires build.serve.transport.json;
2929
requires build.serve.websocket;
@@ -40,4 +40,10 @@
4040
requires java.net.http;
4141
requires gg.jte.runtime;
4242
requires gg.jte;
43+
44+
opens build.serve.example to com.fasterxml.jackson.databind;
45+
opens build.serve.example.api to com.fasterxml.jackson.databind;
46+
opens build.serve.example.domain to com.fasterxml.jackson.databind, com.graphqljava;
47+
opens build.serve.example.graphql to com.fasterxml.jackson.databind;
48+
opens gg.jte.generated.precompiled to gg.jte.runtime;
4349
}

0 commit comments

Comments
 (0)