Skip to content

Commit 038a62d

Browse files
committed
review fixes
1 parent 7fdc9d8 commit 038a62d

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

extension-admob/src/admob_ios.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -547,7 +547,7 @@ void Initialize_Ext(dmExtension::Params* params, const char* defoldUserAgent) {
547547
admobExtAppOpenAdDelegate = [[AdmobExtAppOpenAdDelegate alloc] init];
548548
admobAppDelegate = [[AdMobAppDelegate alloc] init];
549549

550-
appOpenAdId = (char*)dmConfigFile::GetString(params->m_ConfigFile, "admob.app_open_ios", 0);
550+
appOpenAdId = (char*)dmConfigFile::GetString(params->m_ConfigFile, "admob.app_open_ios", "");
551551
if (appOpenAdId && strlen(appOpenAdId) > 0) {
552552
LoadAppOpen(appOpenAdId, true);
553553
}

main/ads.gui_script

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ local function set_block_height(height)
6969
gui.set_size(height_b_node, size)
7070
end
7171

72+
if admob then
7273
local EVENT_TEXTS = {
7374
[admob.EVENT_CLOSED] = "EVENT_CLOSED: %s closed",
7475
[admob.EVENT_FAILED_TO_SHOW] = "EVENT_FAILED_TO_SHOW: %s failed to show",
@@ -81,6 +82,8 @@ local EVENT_TEXTS = {
8182
[admob.EVENT_CLICKED] = "EVENT_CLICKED: %s clicked",
8283
[admob.EVENT_JSON_ERROR] = "EVENT_JSON_ERROR: %s Internal NE json error",
8384
}
85+
end
86+
8487
local function print_event(ad_type, message)
8588
local text = EVENT_TEXTS[message.event]
8689
if text then

0 commit comments

Comments
 (0)