Smart border inpainting mode #176
Conversation
from #74 sets border = 'smart' by default
Co-Authored-By: Funofabot <[email protected]>
|
Uhh, freezes again 😩 |
|
Now I'll use #78 as an inspiration to help fix these issues |
finally fixed not diffusing Co-Authored-By: Funofabot <[email protected]>
|
now it's a mess in 3D mode instead 😞 |
|
I will review this, did you happen to look at the branch I made to make this, I found stuff in reset pipeline in my last run on this. Ill do a full review tonight. I want this change. I want the reset pipeline in its own file. reset_webui_pipeline.py to remove it from generate.py. But we can address that when I do the review. I had thoughts on cadence as well because this wont cover cadence and we need to address it. Ill test your iteration to see. |
|
I cannot get to this tonight. If you have time, make the changes I replied in DM in discord. I want the larger functionality moved to individual files. So that the code base is more maintainable. I will have time tomorrow and if you do not make the changes I will undoubtedly have changes I want made. Read your DMs from me. But what I am trying to accomplish is that when we split functionality we need to add a new file to encapsulate that functionality so that when we maintain that, its a easy deal. Thank you my friend. You are a wonderful person. N.B. This time we will be able to push this. |
There was a problem hiding this comment.
Not working, it still makes stripes.
I will make something that will enlighten this. I want to save the edits to deforum, args, and settings to not have to rewrite those parts as they are a pain.
I don't think that you need to check for too small of an area, perhaps just check extrema when the mask is generated if its all 1's or white, then set the mask to None. It will get ignored in generate.py
In my version I used a white image as the basis for the warp with zeros as the warp border mode. Then I inverted it to send it as a mask that works in webui pipeline. The reasoning is because grid_sample provides zeros and not ones as a border mode. Otherwise we would start with a black image and fill the border with ones and not need to invert.
The issue with cadence still shows up where it stretches the border or zeros without the extra inpaint steps.
Color correction does not happen to the newly inpainted borders. And that results in in consistency when the strength schedule is high.
I need more time to think about it. Keep this open and it is bound to happen.
|
@Funofabot status? anything? 👯 |
|
Just merged with main and tested, and it's not good. I don't think we should move on with this at its current stage. With the "fix": 20230217075548.mp4Without/ from our main version: 20230217075744.mp4 |
|
Okay, time to scrap it and stop wasting energy on this approach |
Closes #148 Closes #172
Addresses the issue of border stripes, fixes #120
Rewrite of #74 while also getting warp masks directly from depth warping code