Skip to content

invoice object returns a Vec<Parcel> as type "parcel" #333

Open
@bacongobbler

Description

Should these fields be made plural to match other fields?

pub parcel: Option<Vec<Parcel>>,
pub group: Option<Vec<Group>>,
pub signature: Option<Vec<Signature>>,

IMO we should be listing these as "parcels", "groups", and "signatures" as we're dealing with a list of objects rather than a single object.

That being said, this would break backwards compatibility with older bindle clients.

I noticed this while updating bindle-dotnet to the newest bindle APIs.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions