Skip to content

Commit 3b802c1

Browse files
authored
fix: Fix install of regorus_ffi C++ bindings (microsoft#449)
When using a clean build dir the install failed as it referenced a non-existing `regorus_ffiCorrosion.cmake` file. I believe I used the shorter `regorus_ffi` as my `EXPORT` in the `corrosion_install` at some point and then later didn't notice that I referenced a stale generated file when I initially handed in this PR. We must make sure that the same identifier is used here too. See also the documentation from `corrosion_install`: > * **EXPORT**: Creates an export that can be installed with `install(EXPORT)`. <export-name> must be globally unique. > Also creates a file at ${CMAKE_BINARY_DIR}/corrosion/<export-name>Corrosion.cmake that must be included in the installed config file.
1 parent 90b4ec6 commit 3b802c1

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

bindings/cpp/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ configure_package_config_file(${CMAKE_CURRENT_LIST_DIR}/regorus_ffiConfig.cmake.
7575

7676
install(FILES
7777
${CMAKE_CURRENT_BINARY_DIR}/regorus_ffiConfig.cmake
78-
${CMAKE_CURRENT_BINARY_DIR}/corrosion/regorus_ffiCorrosion.cmake
78+
${CMAKE_CURRENT_BINARY_DIR}/corrosion/regorus_ffi_targetsCorrosion.cmake
7979
DESTINATION ${regorus_ffi_CONFIGDIR}
8080
)
8181

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
@PACKAGE_INIT@
22
include("${CMAKE_CURRENT_LIST_DIR}/regorus_ffi_targets.cmake")
3-
include("${CMAKE_CURRENT_LIST_DIR}/regorus_ffiCorrosion.cmake")
3+
include("${CMAKE_CURRENT_LIST_DIR}/regorus_ffi_targetsCorrosion.cmake")

0 commit comments

Comments
 (0)