[node-local-dns] error upgrading to 2.3.0 "field is immutable"

[davidegiunchi]

Hi,
When i try to upgrade via helm from 2.2.10 to 2.3.0 i get the following error:

Error: cannot patch "node-local-dns" with kind DaemonSet: DaemonSet.apps "node-local-dns" is invalid: spec.selector: Invalid value: {"matchLabels":{"app.kubernetes.io/instance":"node-local-dns","app.kubernetes.io/name":"node-local-dns"}}: field is immutable

the only parameter that i've changed from the default when i try to upgrade, is this:

config.healthPort: 8090

thank you,
regards

[max-rocket-internet]

This is normal when selector labels are changed. In this case, the DaemonSet named node-local-dns must be deleted before updating the chart. Be sure to test if this is disruptive for DNS queries in your cluster 🙂

[anthosz]

@max-rocket-internet in this context, seems more a major upgrade than a minor one due to breaking change

[max-rocket-internet]

I think you're right, that's on me, sorry.

[max-rocket-internet]

One solution could be to keep the chart as it is now, using the proper and conventional labels, but add an option to pass the old labels as a value which would allow the chart to be upgraded without impact provided the option was set?