Unit and Integration tests for local repo (#3991)

Author: Rajeshkumar-s2

build_stream/container.py

@@ -295,12 +295,6 @@ class ProdContainer(containers.DeclarativeContainer):  # pylint: disable=R0903
         NfsPlaybookQueueResultRepository,
     )
 
-
-
-
-
-
-
     # --- Local repo services ---
     input_file_service = providers.Factory(
         InputFileService,

build_stream/tests/integration/api/auth/conftest.py

@@ -0,0 +1,38 @@
+# Copyright 2026 Dell Inc. or its subsidiaries. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""Auth API integration fixtures using mock vault credentials."""
+
+import base64
+from typing import Dict
+
+import pytest
+
+from tests.mocks.mock_vault_client import MockVaultClient
+
+
+@pytest.fixture
+def valid_auth_header() -> Dict[str, str]:
+    """Create valid Basic Auth header for registration endpoint."""
+    credentials = base64.b64encode(
+        f"{MockVaultClient.DEFAULT_TEST_USERNAME}:{MockVaultClient.DEFAULT_TEST_PASSWORD}".encode()
+    ).decode()
+    return {"Authorization": f"Basic {credentials}"}
+
+
+@pytest.fixture
+def invalid_auth_header() -> Dict[str, str]:
+    """Create invalid Basic Auth header."""
+    credentials = base64.b64encode(b"wrong_user:wrong_password").decode()
+    return {"Authorization": f"Basic {credentials}"}

build_stream/tests/integration/api/local_repo/__init__.py

@@ -0,0 +1,13 @@
+# Copyright 2026 Dell Inc. or its subsidiaries. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.

build_stream/tests/integration/api/local_repo/conftest.py

@@ -0,0 +1,110 @@
+# Copyright 2026 Dell Inc. or its subsidiaries. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""Shared fixtures for Local Repository API integration tests."""
+
+import os
+from pathlib import Path
+from typing import Dict
+
+import pytest
+from fastapi.testclient import TestClient
+from api.dependencies import verify_token
+
+from main import app
+from infra.id_generator import UUIDv4Generator
+
+
+@pytest.fixture(scope="function")
+def client():
+    """Create test client with fresh container for each test."""
+    os.environ["ENV"] = "dev"
+
+    def mock_verify_token():
+        return {
+            "sub": "test-client-123",
+            "client_id": "test-client-123",
+            "scopes": ["job:write", "job:read"]
+        }
+
+    app.dependency_overrides[verify_token] = mock_verify_token
+
+    test_client = TestClient(app)
+
+    yield test_client
+
+    # Cleanup
+    app.dependency_overrides.clear()
+
+
+@pytest.fixture(name="uuid_generator")
+def uuid_generator_fixture():
+    """UUID generator for test fixtures."""
+    return UUIDv4Generator()
+
+
+@pytest.fixture(name="auth_headers")
+def auth_headers_fixture(uuid_generator) -> Dict[str, str]:
+    """Standard authentication headers for testing."""
+    return {
+        "Authorization": "Bearer test-client-123",
+        "X-Correlation-Id": str(uuid_generator.generate()),
+        "Idempotency-Key": f"test-key-{uuid_generator.generate()}",
+    }
+
+
+@pytest.fixture
+def unique_correlation_id(uuid_generator) -> str:
+    """Generate unique correlation ID for each test."""
+    return str(uuid_generator.generate())
+
+
+@pytest.fixture
+def created_job(client, auth_headers) -> str:
+    """Create a job and return its job_id."""
+    payload = {"client_id": "test-client-123", "client_name": "test-client"}
+    response = client.post("/api/v1/jobs", json=payload, headers=auth_headers)
+    assert response.status_code == 201
+    return response.json()["job_id"]
+
+
+@pytest.fixture
+def nfs_queue_dir(tmp_path):
+    """Create temporary NFS queue directory structure."""
+    requests_dir = tmp_path / "requests"
+    results_dir = tmp_path / "results"
+    archive_dir = tmp_path / "archive" / "results"
+    processing_dir = tmp_path / "processing"
+
+    requests_dir.mkdir(parents=True)
+    results_dir.mkdir(parents=True)
+    archive_dir.mkdir(parents=True)
+    processing_dir.mkdir(parents=True)
+
+    return tmp_path
+
+
+@pytest.fixture
+def input_dir(tmp_path):
+    """Create temporary input directory with sample files."""
+    base = tmp_path / "build_stream"
+    return base
+
+
+def setup_input_files(input_dir_path: Path, job_id: str) -> Path:
+    """Create input files for a given job_id."""
+    job_input = input_dir_path / job_id / "input"
+    job_input.mkdir(parents=True, exist_ok=True)
+    (job_input / "config.json").write_text('{"cluster_os": "rhel9.2"}')
+    return job_input

build_stream/tests/integration/api/local_repo/test_create_local_repo_api.py

@@ -0,0 +1,179 @@
+# Copyright 2026 Dell Inc. or its subsidiaries. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""Integration tests for Local Repository create API."""
+
+from unittest.mock import patch
+
+from tests.integration.api.local_repo.conftest import setup_input_files
+
+
+class TestCreateLocalRepoSuccess:
+    """Happy-path create local repository tests."""
+
+    def test_returns_202_with_valid_request(
+        self, client, auth_headers, created_job, nfs_queue_dir, input_dir
+    ):
+        setup_input_files(input_dir, created_job)
+
+        with patch(
+            "infra.repositories.nfs_input_repository"
+            ".NfsInputRepository.get_source_input_repository_path",
+            return_value=input_dir / created_job / "input",
+        ), patch(
+            "infra.repositories.nfs_input_repository"
+            ".NfsInputRepository.get_destination_input_repository_path",
+            return_value=nfs_queue_dir / "dest_input",
+        ), patch(
+            "infra.repositories.nfs_input_repository"
+            ".NfsInputRepository.validate_input_directory",
+            return_value=True,
+        ), patch(
+            "infra.repositories.nfs_playbook_queue_request_repository"
+            ".NfsPlaybookQueueRequestRepository.is_available",
+            return_value=True,
+        ), patch(
+            "infra.repositories.nfs_playbook_queue_request_repository"
+            ".NfsPlaybookQueueRequestRepository.write_request",
+            return_value=nfs_queue_dir / "requests" / "test.json",
+        ):
+            response = client.post(
+                f"/api/v1/jobs/{created_job}/stages/create-local-repository",
+                headers=auth_headers,
+            )
+
+        assert response.status_code == 202
+        data = response.json()
+        assert data["job_id"] == created_job
+        assert data["stage"] == "create-local-repository"
+        assert data["status"] == "accepted"
+        assert "submitted_at" in data
+        assert "correlation_id" in data
+
+    def test_returns_correlation_id(
+        self, client, created_job, unique_correlation_id,
+        nfs_queue_dir, input_dir
+    ):
+        setup_input_files(input_dir, created_job)
+        headers = {
+            "Authorization": "Bearer test-client-123",
+            "X-Correlation-Id": unique_correlation_id,
+        }
+
+        with patch(
+            "infra.repositories.nfs_input_repository"
+            ".NfsInputRepository.get_source_input_repository_path",
+            return_value=input_dir / created_job / "input",
+        ), patch(
+            "infra.repositories.nfs_input_repository"
+            ".NfsInputRepository.get_destination_input_repository_path",
+            return_value=nfs_queue_dir / "dest_input",
+        ), patch(
+            "infra.repositories.nfs_input_repository"
+            ".NfsInputRepository.validate_input_directory",
+            return_value=True,
+        ), patch(
+            "infra.repositories.nfs_playbook_queue_request_repository"
+            ".NfsPlaybookQueueRequestRepository.is_available",
+            return_value=True,
+        ), patch(
+            "infra.repositories.nfs_playbook_queue_request_repository"
+            ".NfsPlaybookQueueRequestRepository.write_request",
+            return_value=nfs_queue_dir / "requests" / "test.json",
+        ):
+            response = client.post(
+                f"/api/v1/jobs/{created_job}/stages/create-local-repository",
+                headers=headers,
+            )
+
+        assert response.status_code == 202
+        assert response.json()["correlation_id"] == unique_correlation_id
+
+
+class TestCreateLocalRepoValidation:
+    """Validation scenarios for create local repository."""
+
+    def test_invalid_job_id_returns_400(self, client, auth_headers):
+        response = client.post(
+            "/api/v1/jobs/invalid-uuid/stages/create-local-repository",
+            headers=auth_headers,
+        )
+        assert response.status_code == 400
+        detail = response.json()["detail"]
+        assert detail["error"] == "INVALID_JOB_ID"
+
+    def test_nonexistent_job_returns_404(self, client, auth_headers):
+        fake_job_id = "018f3c4c-6a2e-7b2a-9c2a-3d8d2c4b9a11"
+        response = client.post(
+            f"/api/v1/jobs/{fake_job_id}/stages/create-local-repository",
+            headers=auth_headers,
+        )
+        assert response.status_code == 404
+        detail = response.json()["detail"]
+        assert detail["error"] == "JOB_NOT_FOUND"
+
+
+class TestCreateLocalRepoAuthentication:
+    """Authentication header tests."""
+
+    def test_missing_authorization_returns_422(self, client, created_job):
+        headers = {
+            "X-Correlation-Id": "019bf590-1234-7890-abcd-ef1234567890",
+        }
+        response = client.post(
+            f"/api/v1/jobs/{created_job}/stages/create-local-repository",
+            headers=headers,
+        )
+        assert response.status_code == 422
+
+    def test_invalid_authorization_format_returns_401(self, client, created_job):
+        headers = {
+            "Authorization": "InvalidFormat test-token",
+            "X-Correlation-Id": "019bf590-1234-7890-abcd-ef1234567890",
+        }
+        response = client.post(
+            f"/api/v1/jobs/{created_job}/stages/create-local-repository",
+            headers=headers,
+        )
+        assert response.status_code == 401
+
+    def test_empty_bearer_token_returns_401(self, client, created_job):
+        headers = {
+            "Authorization": "Bearer ",
+            "X-Correlation-Id": "019bf590-1234-7890-abcd-ef1234567890",
+        }
+        response = client.post(
+            f"/api/v1/jobs/{created_job}/stages/create-local-repository",
+            headers=headers,
+        )
+        assert response.status_code == 401
+
+
+class TestCreateLocalRepoInputValidation:
+    """Input file validation tests."""
+
+    def test_missing_input_files_returns_400(self, client, auth_headers, created_job):
+        with patch(
+            "infra.repositories.nfs_input_repository"
+            ".NfsInputRepository.validate_input_directory",
+            return_value=False,
+        ):
+            response = client.post(
+                f"/api/v1/jobs/{created_job}/stages/create-local-repository",
+                headers=auth_headers,
+            )
+
+        assert response.status_code == 400
+        detail = response.json()["detail"]
+        assert detail["error"] == "INPUT_FILES_MISSING"