-
Couldn't load subscription status.
- Fork 118
test: add memory tests (via DHAT) #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b805f6c to
90f6dc2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
=======================================
Coverage 84.83% 84.83%
=======================================
Files 113 113
Lines 28735 28735
Branches 28735 28735
=======================================
Hits 24376 24376
Misses 3203 3203
Partials 1156 1156 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
90f6dc2 to
94e7a21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I know how DHAT works... can you given an example of expected output in the PR description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems useful. We can iterate as needed.
|
|
||
| #[ignore = "mem-test - run manually"] | ||
| #[test] | ||
| fn test_dhat_large_table_log() -> Result<(), Box<dyn std::error::Error>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof
Failed to get latest snapshot: ObjectStore(Generic { store: "LocalFileSystem", source: UnableToOpenFile { source: Os { code: 24, kind: Uncategorized, message: "Too many open files" }, path: "/var/folders/cr/cl0ybfwx6kjd8bybfc2mr4rw0000gp/T/.tmpapqcBg/_delta_log/00000000000000000749.json" } })
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah macos? i think might need to bump up ulimit
|
@scovich Here's the output that didn't crash: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved for now as this is purely additive and we can iterate on exactly what we want to do with them
What changes are proposed in this pull request?
exploring DHAT tests for memory profiling. this adds two ignored tests in a separate (new)
mem-testinternal crate.run with:
cargo test -p mem-test -- --ignored --nocaptureHow was this change tested?
test-only