refactor: remove storing UUID in LogPathFileType::UuidCheckpoint #1317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksandarskrbic
changed the title
github-actions
bot
added
the
breaking-change
zachschuermann
requested review from
OussamaSaoudi,
nicklan and
zachschuermann
zachschuermann
changed the title
Co-authored-by: OussamaSaoudi <[email protected]>
scovich
approved these changes
Sep 25, 2025
| ["checkpoint", uuid, "json" | "parquet"] => { | ||
| let uuid = parse_path_part(uuid, UUID_PART_LEN, url)?; | ||
| LogPathFileType::UuidCheckpoint(uuid) | ||
| let _ = parse_path_part::<String>(uuid, UUID_PART_LEN, url)?; |
There was a problem hiding this comment.
Do we actually care that it's a valid UUID if we never use it for anything but a filename?
(but the Delta spec does say it must be a UUID, so I guess we have to)
There was a problem hiding this comment.
Yeah I think we might as well verify it
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
==========================================
- Coverage 84.81% 84.79% -0.03%
==========================================
Files 113 113
Lines 28647 28642 -5
Branches 28647 28642 -5
==========================================
- Hits 24297 24286 -11
- Misses 3196 3197 +1
- Partials 1154 1159 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1307