don't need a whole engine when converting into ArrowEngineData
#1325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1325 +/- ##
=======================================
Coverage 84.19% 84.20%
=======================================
Files 111 111
Lines 27434 27438 +4
Branches 27434 27438 +4
=======================================
+ Hits 23099 23103 +4
Misses 3203 3203
Partials 1132 1132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DrakeLin
approved these changes
Sep 18, 2025
aleksandarskrbic
pushed a commit
to aleksandarskrbic/delta-kernel-rs
that referenced
this pull request
Sep 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
We were asking for a whole engine over ffi just to be able to convert the error. Let's just take an
AllocateErrorFninstead.This PR affects the following public APIs
in the ffi crate:
engine_data::get_engine_datanow takes anAllocateErrorFninstead of an engine.How was this change tested?
Existing tests