-
Couldn't load subscription status.
- Fork 118
refactor: pull out transform spec utils and definitions #1326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: pull out transform spec utils and definitions #1326
Conversation
cae3732 to
4594949
Compare
4594949 to
630663b
Compare
2c91a87 to
42b7500
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1326 +/- ##
==========================================
+ Coverage 84.28% 84.39% +0.11%
==========================================
Files 111 112 +1
Lines 27641 27773 +132
Branches 27641 27773 +132
==========================================
+ Hits 23296 23440 +144
+ Misses 3215 3201 -14
- Partials 1130 1132 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e533c1e to
f5e84e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one comment. I love that we're consolidating all this.
kernel/src/lib.rs
Outdated
| pub mod table_features; | ||
| pub mod table_properties; | ||
| pub mod transaction; | ||
| pub mod transforms; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there's nothing public, I think we can just make this pub(crate). If things break, just keep it pub mod
| pub mod transforms; | |
| pub(crate) mod transforms; |
|
This isn't a breaking change, so pls remove the breaking change label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, l lgtm! thanks, let's just make this pub(crate) as Oussama suggested
booo github actions booooo |
f5e84e0 to
281b620
Compare
281b620 to
e15f8ea
Compare
What changes are proposed in this pull request?
Moved partition value parsing, transform expression generation, and transform spec computation from log_replay.rs into a new dedicated transform_processing.rs module. This improves code organization and reusability.
This is a prefactor for CDF TransformSpec support
How was this change tested?
Existing tests