chore!: Make StructType::into_fields return type consistent #1327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1327 +/- ##
==========================================
+ Coverage 84.22% 84.23% +0.01%
==========================================
Files 111 111
Lines 27495 27497 +2
Branches 27495 27497 +2
==========================================
+ Hits 23158 23163 +5
+ Misses 3204 3203 -1
+ Partials 1133 1131 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fokko
approved these changes
Sep 19, 2025
|
Great catch @lbhm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
#1287 extended the return type of
StructType::fieldswith new traits that #1266 did not pick up for the newly introducedStructType::into_fields. This PR fixes that.This PR affects the following public APIs
This PR extends the return type of the public API
StructType::into_fields. Since we are only adding additional traits to the return type, all existing use cases should continue to work.How was this change tested?
Refactoring only - existing tests verify correctness.