-
Couldn't load subscription status.
- Fork 118
refactor!: Snapshot should not expose delta implementation details #1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Snapshot should not expose delta implementation details #1339
Conversation
|
please rename to |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1339 +/- ##
==========================================
+ Coverage 84.90% 84.91% +0.01%
==========================================
Files 113 113
Lines 28923 28948 +25
Branches 28923 28948 +25
==========================================
+ Hits 24556 24581 +25
Misses 3197 3197
Partials 1170 1170 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Could you rebase please? We'll try to get this in right after :) |
Done :) @OussamaSaoudi |
|
Hey, still seeing clippy issues. Take a look at CI and make sure it all passes. ex: |
6b775fc to
8bbdee7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks!
|
ah darn this fell out of sync 😭 could you rebase one more time please? |
40d651d to
8bbdee7
Compare
8bbdee7 to
aa1b0d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but can we please make sure to call out breaking changes (or any changes) in PR description
|
Updated the description. @aleksandarskrbic in the future please be sure to follow our PR template so that building the changlog is easier. Thank you for your contribution! :D |
Fixes #648
Why this is a breaking change:
This PR removes
Snapshot::metadata,Snapshot::protocol, andSnapshot::column_mapping_mode. These are now all accessed throughsnapshot.table_configuration