test: Tombstone expiration e2e test for log compaction #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1341 +/- ##
=======================================
Coverage 84.80% 84.80%
=======================================
Files 113 113
Lines 28642 28642
Branches 28642 28642
=======================================
Hits 24289 24289
Misses 3196 3196
Partials 1157 1157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
the
breaking-change
anoopj
commented
Sep 30, 2025
| batch.into_parts().0, | ||
| )) | ||
| }); | ||
| let compaction_data_iter = compacted_data_batches.into_iter().map(Ok); |
There was a problem hiding this comment.
Fixed this bug in the test.
zachschuermann
approved these changes
Oct 1, 2025
OussamaSaoudi
requested review from
OussamaSaoudi
and removed request for
nicklan
OussamaSaoudi
approved these changes
Oct 1, 2025
Co-authored-by: OussamaSaoudi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add a new end to end test for tombstone expiration in log compaction writer we introduced in
#1234
Fixes: #1288