refactor: Make Metadata fields private
#1347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR resolves #1296 and refactors the fields of
Metadatato make them private.The change forces all callers to instantiate
Metadatavia thetry_newfunction. Otherwise, we cannot guarantee that metadata columns never leak to the Delta log, as callers might directly instantiate aMetadatainstance with an illegal table schema.This PR affects the following public APIs
None. All
Metadatafields have beenpub(crate).How was this change tested?
This is a pure refactoring. Existing tests verify correctness.