-
Couldn't load subscription status.
- Fork 118
Allow passing more on the command line for all the cli examples #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1352 +/- ##
=======================================
Coverage 84.79% 84.79%
=======================================
Files 113 113
Lines 28613 28613
Branches 28613 28613
=======================================
Hits 24263 24263
Misses 3196 3196
Partials 1154 1154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (for the future) should we consider making an actual "utility" as an actual binary? i suppose cargo examples are basically that but it might be 'nicer' to separate some exemplary stuff from actual utils?
| HashMap::from([("region", region.clone())]) | ||
| if args.env_creds { | ||
| let (scheme, _path) = ObjectStoreScheme::parse(url).map_err(|e| { | ||
| delta_kernel::Error::Generic(format!("Object store could not parse url: {}", e)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
| delta_kernel::Error::Generic(format!("Object store could not parse url: {}", e)) | |
| delta_kernel::Error::generic(format!("Object store could not parse url: {e}")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually not, because it's already a String because I'm using format!. So we'll being doing an unneeded to_string() if we use generic.
|
Agreed with @zachschuermann we should have a cli tool for quickly reading/inspecting delta tables |
|
So, these are actually their own crates, they just happen to live in a directory named |
What changes are proposed in this pull request?
We discussed that we want to be able to point examples (and a future "telemetry example") at tables in cloud storage. This introduces ways to pass all the credentials/config in our examples, and adds some usage examples to each one.
It also migrates
write-tableto usecommon.How was this change tested?
Running the examples
help output for
read-table-single-threaded: