-
Couldn't load subscription status.
- Fork 118
fix: Change InCommitTimestamp enablement getter function #1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change InCommitTimestamp enablement getter function #1357
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1357 +/- ##
==========================================
+ Coverage 84.79% 84.81% +0.01%
==========================================
Files 113 113
Lines 28613 28647 +34
Branches 28613 28647 +34
==========================================
+ Hits 24263 24297 +34
Misses 3196 3196
Partials 1154 1154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanna add that one clarifying comment :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM awesome
What changes are proposed in this pull request?
#1356
The in_commit_timestamp_enablement() method returns errors when ICT is enabled but enablement properties are missing, violating the Delta protocol. When table is created with ICT enablement info, the enablement properties will stay empty.
This change introduces a new enum to capture ICT enablement.
How was this change tested?
New and edited unit tests