Skip to content

Conversation

@DrakeLin
Copy link
Collaborator

What changes are proposed in this pull request?

#1356

The in_commit_timestamp_enablement() method returns errors when ICT is enabled but enablement properties are missing, violating the Delta protocol. When table is created with ICT enablement info, the enablement properties will stay empty.

This change introduces a new enum to capture ICT enablement.

How was this change tested?

New and edited unit tests

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.81%. Comparing base (af78ccb) to head (989a871).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/table_configuration.rs 96.29% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1357      +/-   ##
==========================================
+ Coverage   84.79%   84.81%   +0.01%     
==========================================
  Files         113      113              
  Lines       28613    28647      +34     
  Branches    28613    28647      +34     
==========================================
+ Hits        24263    24297      +34     
  Misses       3196     3196              
  Partials     1154     1154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@OussamaSaoudi OussamaSaoudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanna add that one clarifying comment :)

Copy link
Member

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM awesome

@DrakeLin DrakeLin merged commit d3c7323 into delta-io:main Sep 30, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants