feat: Convert DV storage_type to enum
#1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1366 +/- ##
==========================================
+ Coverage 84.83% 84.87% +0.04%
==========================================
Files 113 113
Lines 28735 28796 +61
Branches 28735 28796 +61
==========================================
+ Hits 24376 24442 +66
+ Misses 3203 3197 -6
- Partials 1156 1157 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zachschuermann
requested review from
OussamaSaoudi,
nicklan and
zachschuermann
Fokko
force-pushed
the
fd-convert-dv-storage-type-to-enum
branch
2 times, most recently
from
76013c6 to
bb2d651
Compare
Fokko
force-pushed
the
fd-convert-dv-storage-type-to-enum
branch
from
bb2d651 to
7404837
Compare
OussamaSaoudi
approved these changes
Oct 2, 2025
zachschuermann
approved these changes
Oct 3, 2025
Comment on lines
+28
to
+42
| impl FromStr for DeletionVectorStorageType { | ||
| type Err = Error; | ||
|
|
||
| fn from_str(s: &str) -> DeltaResult<Self> { | ||
| match s { | ||
| "u" => Ok(Self::PersistedRelative), | ||
| "i" => Ok(Self::Inline), | ||
| "p" => Ok(Self::PersistedAbsolute), | ||
| _ => Err(Error::internal_error(format!( | ||
| "Unsupported deletion vector format option: {}", | ||
| s | ||
| ))), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we could use strum for this (as we do with some other enums IIRC) but not a huge opinion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
I've been playing around with the Deletion Vectors, and I thought it would be a nice touch to convert the string to an enum. This makes the code more readable and avoids the catch-all branch in the pattern matching.
How was this change tested?
Existing tests.