fix: be adaptive to the log schema changing in inspect-table #1368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
We were hard coding the number of expected leaf fields we would get when visiting log data. This meant any changes to the log schema would silently break this example. We already have code to extract the offsets of the getters within the schema, so we should just adapt to changes (although reordering the schema would be bad).
This PR just computes the expected number of getters from the number of leaves in the schema, and ensures that's what we get back from the visitor, instead of hard-coding the number.
How was this change tested?
Run example on existing tables