Skip to content

Conversation

@nicklan
Copy link
Collaborator

@nicklan nicklan commented Oct 2, 2025

What changes are proposed in this pull request?

We were hard coding the number of expected leaf fields we would get when visiting log data. This meant any changes to the log schema would silently break this example. We already have code to extract the offsets of the getters within the schema, so we should just adapt to changes (although reordering the schema would be bad).

This PR just computes the expected number of getters from the number of leaves in the schema, and ensures that's what we get back from the visitor, instead of hard-coding the number.

How was this change tested?

Run example on existing tables

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.90%. Comparing base (82fa82e) to head (ffa82f8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1368      +/-   ##
==========================================
+ Coverage   84.89%   84.90%   +0.01%     
==========================================
  Files         113      113              
  Lines       28923    28923              
  Branches    28923    28923              
==========================================
+ Hits        24553    24556       +3     
+ Misses       3198     3197       -1     
+ Partials     1172     1170       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nicklan nicklan requested review from OussamaSaoudi and roeap October 2, 2025 20:29
Copy link
Member

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicklan nicklan merged commit e1faff7 into delta-io:main Oct 6, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants