chore: Remove comfy-table pin
#1371
Conversation
github-actions
bot
added
the
breaking-change
Zach's fix has been released: https://github.com/apache/arrow-rs/releases/tag/56.2.0
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1371 +/- ##
==========================================
+ Coverage 84.89% 84.90% +0.01%
==========================================
Files 113 113
Lines 28923 28923
Branches 28923 28923
==========================================
+ Hits 24553 24556 +3
+ Misses 3198 3197 -1
+ Partials 1172 1170 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kernel/Cargo.toml
Outdated
|
|
||
| arrow-55 = ["dep:arrow_55", "dep:parquet_55", "object_store", "comfy-table"] | ||
| arrow-56 = ["dep:arrow_56", "dep:parquet_56", "object_store", "comfy-table"] | ||
| arrow-55 = ["dep:arrow_55", "dep:parquet_55", "object_store"] |
There was a problem hiding this comment.
It hasn't been released for the 55 branch 😢
There was a problem hiding this comment.
ah ... should we just make this PR bump to arrow 56.2 and remove comfy-table stuff for that? But then leave it for 55?
There was a problem hiding this comment.
(also surprised this passes tests? - shouldn't MSRV fail for arrow 55 target? i guess maybe we don't test MSRV specifically for 55?)
There was a problem hiding this comment.
Yes, I was hoping to get rid of the TODO, but it looks like we need to keep it around a bit longer. Updated the PR 👍
2 participants
Zach's fix has been released:
https://github.com/apache/arrow-rs/releases/tag/56.2.0
What changes are proposed in this pull request?
How was this change tested?