feat: no staged commits in checkpoint/compaction #1374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1374 +/- ##
==========================================
+ Coverage 84.87% 84.90% +0.02%
==========================================
Files 114 114
Lines 28971 29060 +89
Branches 28971 29060 +89
==========================================
+ Hits 24588 24672 +84
- Misses 3213 3214 +1
- Partials 1170 1174 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zachschuermann
force-pushed
the
no-staged-checkpoint-compact
branch
from
eb5367c to
6df0dc8
Compare
scovich
approved these changes
Oct 9, 2025
samansmink
pushed a commit
to samansmink/delta-kernel-rs
that referenced
this pull request
Oct 19, 2025
## What changes are proposed in this pull request? This PR adds new validation to ensure we don't write checkpoints/compaction whenever we have staged commits in the LogSegment. We want to prohibit this to prevent creating gaps in the log (if we allow checkpoint at version N but that version only has staged commit then old readers will break instead of just returning stale reads as in the intention of catalogManaged tables) ### details Since we generally treat staged commits as an encapsulated detail of `LogSegment`, we expose a new internal api `LogSegment::validate_no_staged_commits` and inject calls in our checkpoint writer and log compaction writer to ensure we don't write checkpoints/compactions for log segments with staged commits. ## How was this change tested? new UTs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR adds new validation to ensure we don't write checkpoints/compaction whenever we have staged commits in the LogSegment. We want to prohibit this to prevent creating gaps in the log (if we allow checkpoint at version N but that version only has staged commit then old readers will break instead of just returning stale reads as in the intention of catalogManaged tables)
details
Since we generally treat staged commits as an encapsulated detail of
LogSegment, we expose a new internal apiLogSegment::validate_no_staged_commitsand inject calls in our checkpoint writer and log compaction writer to ensure we don't write checkpoints/compactions for log segments with staged commits.How was this change tested?
new UTs