feat: pass ColumnMappingMode to physical_name #1403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1120
What changes are proposed in this pull request?
This PR makes StructField::physical_name() aware of ColumnMappingMode by adding it as a required parameter.
Previously, physical_name() would always return the physical name from metadata if present, regardless of the column mapping mode. This was incorrect behavior - when column mapping mode is
None, the logical name should be used even if physical name metadata exists in the field.
The key changes are: